Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC/refactor: code-split ui package #234

Merged
merged 8 commits into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/app/(user)/forgot/ForgotForm.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";
import React, { FormEvent, useState } from "react";
import { Button } from "ui";
import { Button } from "ui/button";
import { supabase } from "lib/supabase";

export default function ForgotForm() {
Expand Down
4 changes: 2 additions & 2 deletions core/app/(user)/login/LoginForm.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";
import React, { useState, FormEvent } from "react";
import { Button } from "ui";
import { Button } from "ui/button";
import { supabase } from "lib/supabase";
import Link from "next/link";
import { useRouter } from "next/navigation";
Expand Down Expand Up @@ -38,7 +38,7 @@ export default function LoginForm() {
router.push("/settings");
}
}
}
};

return (
<div className="border p-4">
Expand Down
2 changes: 1 addition & 1 deletion core/app/(user)/reset/ResetForm.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";
import React, { useState, FormEvent } from "react";
import { Button } from "ui";
import { Button } from "ui/button";
import { formatSupabaseError, supabase } from "lib/supabase";
import { useRouter } from "next/navigation";

Expand Down
3 changes: 2 additions & 1 deletion core/app/(user)/settings/SettingsForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import { supabase } from "lib/supabase";
import Link from "next/link";
import { useRouter } from "next/navigation";
import { FormEvent, useState } from "react";
import { Avatar, AvatarFallback, AvatarImage, Button } from "ui";
import { Button } from "ui/button";
import { Avatar, AvatarFallback, AvatarImage } from "ui/avatar";
import LogoutButton from "~/app/components/LogoutButton";
import { UserPutBody, UserSettings } from "~/lib/types";

Expand Down
2 changes: 1 addition & 1 deletion core/app/(user)/signup/SignupForm.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";
import React, { useState, FormEvent } from "react";
import { Button } from "ui";
import { Button } from "ui/button";
import { UserPostBody } from "~/lib/types";

export default function SignupForm() {
Expand Down
6 changes: 2 additions & 4 deletions core/app/c/[communitySlug]/CommunitySwitcher.tsx
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import Link from "next/link";
import { Avatar, AvatarFallback, AvatarImage } from "ui/avatar";
import {
Avatar,
AvatarFallback,
AvatarImage,
DropdownMenu,
DropdownMenuItem,
DropdownMenuContent,
DropdownMenuTrigger,
} from "ui";
} from "ui/dropdown-menu";
import { CommunityData } from "./layout";

type Props = {
Expand Down
7 changes: 5 additions & 2 deletions core/app/c/[communitySlug]/LoginSwitcher.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { getLoginData } from "~/lib/auth/loginData";
import { Avatar, AvatarFallback, AvatarImage, Button } from "ui";
import { Avatar, AvatarFallback, AvatarImage } from "ui/avatar";
import { Button } from "ui/button";
import LogoutButton from "../../components/LogoutButton";
import Link from "next/link";

Expand Down Expand Up @@ -27,7 +28,9 @@ export default async function LoginSwitcher() {
<div className="mt-1 flex flex-row items-">
<LogoutButton />
<Link className="ml-2" href="/settings">
<Button variant="outline" size="sm">Settings</Button>
<Button variant="outline" size="sm">
Settings
</Button>
</Link>
</div>
</div>
Expand Down
4 changes: 3 additions & 1 deletion core/app/c/[communitySlug]/integrations/IntegrationsList.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
"use client";

import NextLink from "next/link";
import { Button, Card, CardContent, CardHeader } from "ui";

import { Button } from "ui/button";
import { Card, CardContent, CardHeader } from "ui/card";
import { IntegrationData } from "./page";
import { Row, RowContent, RowFooter } from "~/app/components/Row";

Expand Down
2 changes: 1 addition & 1 deletion core/app/c/[communitySlug]/pubs/PubHeader.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Link from "next/link";
import { Button } from "ui";
import { Button } from "ui/button";

type Props = {};

Expand Down
18 changes: 5 additions & 13 deletions core/app/c/[communitySlug]/pubs/[pubId]/page.tsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,11 @@
import { Prisma, PubField, PubFieldSchema, PubValue } from "@prisma/client";
import { AnySchema, JSONSchemaType } from "ajv";
import Link from "next/link";
import {
Avatar,
AvatarFallback,
AvatarImage,
Button,
CardContent,
CardHeader,
CardTitle,
HoverCard,
HoverCardContent,
HoverCardTrigger,
Separator,
} from "ui";
import { Avatar, AvatarFallback, AvatarImage } from "ui/avatar";
import { Button } from "ui/button";
import { CardContent, CardHeader, CardTitle } from "ui/card";
import { HoverCard, HoverCardContent, HoverCardTrigger } from "ui/hover-card";
import { Separator } from "ui/separator";

import IntegrationActions from "~/app/components/IntegrationActions";
import { PubTitle } from "~/app/components/PubTitle";
Expand Down
20 changes: 6 additions & 14 deletions core/app/c/[communitySlug]/stages/components/Assign.tsx
Original file line number Diff line number Diff line change
@@ -1,20 +1,12 @@
"use client";
import Image from "next/image";
import React from "react";
import {
Button,
Card,
CardContent,
CardFooter,
CardTitle,
Dialog,
DialogContent,
DialogTrigger,
Popover,
PopoverContent,
PopoverTrigger,
useToast,
} from "ui";
import { Button } from "ui/button";
import { Card, CardContent, CardFooter, CardTitle } from "ui/card";
import { Dialog, DialogContent, DialogTrigger } from "ui/dialog";
import { Popover, PopoverContent, PopoverTrigger } from "ui/popover";
import { useToast } from "ui/use-toast";

import {
PermissionPayloadUser,
PubPayload,
Expand Down
4 changes: 3 additions & 1 deletion core/app/c/[communitySlug]/stages/components/Move.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
"use client";
import { Button, Popover, PopoverContent, PopoverTrigger, useToast } from "ui";
import { Button } from "ui/button";
import { useToast } from "ui/use-toast";
import { Popover, PopoverContent, PopoverTrigger } from "ui/popover";
import { PubPayload, StagePayload, StagePayloadMoveConstraintDestination } from "~/lib/types";
import { move } from "./lib/actions";

Expand Down
2 changes: 1 addition & 1 deletion core/app/c/[communitySlug]/stages/components/StageList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import Link from "next/link";
import { Fragment } from "react";
import { Button } from "ui";
import { Button } from "ui/button";
import PubRow from "~/app/components/PubRow";
import { getPubUsers } from "~/lib/permissions";
import { StagesById, StagePayload, UserLoginData } from "~/lib/types";
Expand Down
3 changes: 2 additions & 1 deletion core/app/c/[communitySlug]/stages/manage/StageEditor.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { useState } from "react";
import { Tabs, TabsContent, TabsList, TabsTrigger, toast } from "ui";
import { Tabs, TabsContent, TabsList, TabsTrigger } from "ui/tabs";
import { toast } from "ui/use-toast";
import { StageFormSchema, moveConstraintSourcesForStage } from "~/lib/stages";
import { DeepPartial, StagesById, StagePayload } from "~/lib/types";
import StageForm from "./StageForm";
Expand Down
8 changes: 4 additions & 4 deletions core/app/c/[communitySlug]/stages/manage/StageForm.tsx
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import { useCallback, useEffect } from "react";
import { useForm } from "react-hook-form";
import { Button } from "ui/button";
import {
Button,
Form,
FormControl,
FormDescription,
FormField,
FormItem,
FormLabel,
FormMessage,
Icon,
Input,
} from "ui";
} from "ui/form";
import * as Icon from "ui/icon";
import { Input } from "ui/input";
import { assert } from "utils";
import { StageFormSchema } from "~/lib/stages";
import { StagePayload, StagesById, DeepPartial } from "~/lib/types";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use client";

import { useState } from "react";
import { Tabs, TabsContent, TabsList, TabsTrigger } from "ui";
import { Tabs, TabsContent, TabsList, TabsTrigger } from "ui/tabs";
import StageEditor from "./StageEditor";
import { StagePayload, StagesById } from "~/lib/types";

Expand Down
3 changes: 2 additions & 1 deletion core/app/c/[communitySlug]/types/TypeBlock.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"use client";
import { useState } from "react";
import { Button, Card, CardContent } from "ui";
import { Button } from "ui/button";
import { Card, CardContent } from "ui/card";
import { TypesData } from "./page";

type Props = { type: NonNullable<TypesData>[number] };
Expand Down
2 changes: 1 addition & 1 deletion core/app/components/IntegrationActions.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Popover, PopoverTrigger, Button, PopoverContent } from "ui";
import { Button } from "ui/button";
import { PubPayload } from "~/lib/types";

type Props = {
Expand Down
2 changes: 1 addition & 1 deletion core/app/components/LogoutButton.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
"use client";
import { supabase } from "~/lib/supabase";
import { Button } from "ui";
import { Button } from "ui/button";
import { useRouter } from "next/navigation";

export default function LogoutButton() {
Expand Down
8 changes: 6 additions & 2 deletions core/app/components/PubRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

import Link from "next/link";
import React, { Fragment } from "react";
import { Button, Collapsible, CollapsibleContent, CollapsibleTrigger } from "ui";
import { Button } from "ui/button";
import { Collapsible, CollapsibleContent, CollapsibleTrigger } from "ui/collapsible";
import { cn } from "utils";
import { PubPayload } from "~/lib/types";
import IntegrationActions from "./IntegrationActions";
Expand Down Expand Up @@ -48,7 +49,10 @@ const ChildHierarchy = ({ pub }: { pub: PubPayload["children"][number] }) => {
<span className="text-gray-500 mr-2 font-semibold">
{group.pubType.name}
</span>
<Link href={`/pubs/${child.id}`} className="text-sm hover:underline">
<Link
href={`/pubs/${child.id}`}
className="text-sm hover:underline"
>
{getTitle(child)}
</Link>
</div>
Expand Down
2 changes: 1 addition & 1 deletion core/app/components/Row.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use client";

import { PropsWithChildren } from "react";
import { Card, CardContent, CardFooter, CardHeader } from "ui";
import { Card, CardContent, CardFooter, CardHeader } from "ui/card";
import { cn } from "utils";

type Props = PropsWithChildren<{ className?: string }>;
Expand Down
2 changes: 1 addition & 1 deletion core/app/layout.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Toaster } from "ui";
import { Toaster } from "ui/toaster";
import "ui/styles.css";
import InitClient from "./InitClient";
import "./globals.css";
Expand Down
8 changes: 6 additions & 2 deletions integrations/evaluations/app/actions/evaluate/evaluate.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@ import Ajv from "ajv";
import { fullFormats } from "ajv-formats/dist/formats";
import { useEffect, useMemo } from "react";
import { useForm } from "react-hook-form";
import { Button, Form, Icon, useLocalStorage, useToast } from "ui";
import { Process } from "~/lib/components/Process";
import { Research } from "~/lib/components/Research";
import { EvaluatorWhoAccepted, InstanceConfig } from "~/lib/types";
import { submit, upload } from "./actions";
import { calculateDeadline } from "~/lib/emails";
import { useToast } from "ui/use-toast";
import { useLocalStorage } from "ui/hooks";
import { Form } from "ui/form";
import { Button } from "ui/button";
import { Loader2 } from "ui/icon";

type Props = {
instanceId: string;
Expand Down Expand Up @@ -124,7 +128,7 @@ export function Evaluate(props: Props) {
{formFieldsFromSchema}
<Button type="submit" disabled={!form.formState.isValid}>
{form.formState.isSubmitting && (
<Icon.Loader2 className="h-4 w-4 mr-2 animate-spin" />
<Loader2 className="h-4 w-4 mr-2 animate-spin" />
)}
Submit Evaluation
</Button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,18 @@ import { zodResolver } from "@hookform/resolvers/zod";
import { GetPubResponseBody } from "@pubpub/sdk";
import React, { useCallback } from "react";
import { useFieldArray, useForm } from "react-hook-form";
import {
Button,
Card,
CardContent,
CardDescription,
CardFooter,
CardHeader,
CardTitle,
Form,
FormDescription,
FormItem,
FormLabel,
Icon,
useToast,
} from "ui";
import { cn } from "utils";
import { EmailTemplate, Evaluator, InstanceConfig, hasUser, isInvited, isSaved } from "~/lib/types";
import { EvaluatorInviteFormInviteButton } from "./EvaluatorInviteFormInviteButton";
import { EvaluatorInviteFormSaveButton } from "./EvaluatorInviteFormSaveButton";
import { EvaluatorInviteRow } from "./EvaluatorInviteRow";
import * as actions from "./actions";
import { InviteFormEvaluator, InviteFormSchema } from "./types";
import { useToast } from "ui/use-toast";
import { Form, FormDescription, FormItem, FormLabel } from "ui/form";
import { Button } from "ui/button";
import { Card, CardContent, CardDescription, CardFooter, CardHeader, CardTitle } from "ui/card";
import { Loader2, Plus } from "ui/icon";

type Props = {
evaluators: Evaluator[];
Expand Down Expand Up @@ -223,7 +213,7 @@ export function EvaluatorInviteForm(props: Props) {
/>
))}
<Button variant="ghost" onClick={onAppend} className="color:red-500">
<Icon.Plus className="h-4 w-4 mr-2" />
<Plus className="h-4 w-4 mr-2" />
Add Evaluator
</Button>
</CardContent>
Expand All @@ -235,7 +225,7 @@ export function EvaluatorInviteForm(props: Props) {
</div>
<div className="flex gap-2 items-center">
{form.formState.isSubmitting && (
<Icon.Loader2 className="h-4 w-4 mr-2 animate-spin" />
<Loader2 className="h-4 w-4 mr-2 animate-spin" />
)}
<EvaluatorInviteFormInviteButton
onClick={form.handleSubmit((values) => onSubmit(values, true))}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { useFormState, useWatch } from "react-hook-form";
import { Button, Icon } from "ui";
import { Button } from "ui/button";
import { Send } from "ui/icon";

import { InviteFormSchema } from "./types";

export type EvaluatorInviteFormInviteButtonProps = {
Expand All @@ -16,7 +18,7 @@ export function EvaluatorInviteFormInviteButton(props: EvaluatorInviteFormInvite
!form.evaluators?.some((evaluator) => evaluator.selected) || formState.isSubmitting
}
>
<Icon.Send className="h-4 w-4 mr-2" />
<Send className="h-4 w-4 mr-2" />
Invite
</Button>
);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useFormState } from "react-hook-form";
import { Button, Icon } from "ui";
import { Button } from "ui/button";

export type EvaluatorInviteFormSaveButtonProps = {
onClick: () => void;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@

import { SuggestedMembersQuery } from "@pubpub/sdk";
import { Control, useWatch } from "react-hook-form";
import { Button, FormControl, FormField, FormItem, FormMessage, Icon, Input } from "ui";
import { Button } from "ui/button";
import { Input } from "ui/input";
import { FormControl, FormField, FormItem, FormMessage } from "ui/form";
import { X } from "ui/icon";
import { cn } from "utils";
import { hasUser } from "~/lib/types";
import { EvaluatorInviteRowEmailDialog } from "./EvaluatorInviteRowEmailDialog";
Expand Down Expand Up @@ -115,7 +118,7 @@ export const EvaluatorInviteRow = (props: Props) => {
)}
<EvaluatorInviteRowEmailDialog evaluator={evaluator} index={props.index} />
<Button variant="ghost" onClick={() => props.onRemove(props.index)}>
<Icon.X className="h-4 w-4" />
<X className="h-4 w-4" />
</Button>
</div>
</div>
Expand Down
Loading