-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuration in AWS so core
and jobs
can run healthily
#229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that migrations can be run from that same container
instead of DB_ nonstandard vars
core
and jobs
can run healthily
3mcd
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
The
core
container has not been able to healthcheck due to missing env vars, etc.This PR sets everything in place so that it can run healthily (even if it doesn't do meaningful work yet).
Still TODO:
next build
step?Test Plan
You can see the container running here
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
Changes:
core
.PG*
vars that it needs instead of a.env
file (these are the standard way, it's annoying that Prisma does not support this):
-- these are technically legal for PG passwords, but require complicated handling in application code.deploy
from head of a PR branch if we wantreact-runtime-env
.Supporting Docs