Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration in AWS so core and jobs can run healthily #229

Merged
merged 29 commits into from
Feb 26, 2024

Conversation

ships
Copy link
Collaborator

@ships ships commented Feb 14, 2024

Issue(s) Resolved

The core container has not been able to healthcheck due to missing env vars, etc.

This PR sets everything in place so that it can run healthily (even if it doesn't do meaningful work yet).

Still TODO:

  • diagnose why the frontend complains with something about supabaseUrl required -- seems to suggest that these supabase params are required in the next build step?

Test Plan

You can see the container running here

Screenshots (if applicable)

Optional

Notes/Context/Gotchas

Changes:

  • Dockerfile now copies the generated prisma client directly, when building core.
  • add external service secrets to AWS Secrets Manager
  • .env file in docker context builds database URL using individual env vars
  • jobs container gets the PG* vars that it needs instead of a .env file (these are the standard way, it's annoying that Prisma does not support this)
  • adds a migrations "init container" that uses a container that has the whole monorepo
  • RDS password generation no longer allows special characters like : -- these are technically legal for PG passwords, but require complicated handling in application code.
  • once this is merged, we can manually dispatch a deploy from head of a PR branch if we want
  • NEXT_PUBLIC_ vars are now handled by react-runtime-env.

Supporting Docs

@ships ships changed the title fix import of .prisma in docker Update core configuration in AWS to work well and with good interfaces Feb 18, 2024
@ships ships marked this pull request as ready for review February 20, 2024 01:26
instead of DB_ nonstandard vars
@ships ships changed the title Update core configuration in AWS to work well and with good interfaces Update configuration in AWS so core and jobs can run healthily Feb 20, 2024
@3mcd 3mcd self-requested a review February 26, 2024 20:18
@3mcd 3mcd merged commit 3b2c0a4 into main Feb 26, 2024
4 checks passed
@3mcd 3mcd deleted the ships/core-works-in-docker branch February 26, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants