Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap AWS infrastructure #216

Merged
merged 16 commits into from
Feb 13, 2024
Merged

Bootstrap AWS infrastructure #216

merged 16 commits into from
Feb 13, 2024

Conversation

ships
Copy link
Collaborator

@ships ships commented Feb 1, 2024

Status: WIP.

Issue(s) Resolved

This PR introduces Terraform and Github Actions as declarative infrastructure and change management stack.

Test Plan

Screenshots (if applicable)

Optional

Notes/Context/Gotchas

TODOS:

  • document test plan
  • Enable separation of deploy step from build step entirely. By checking for existence of container image?
  • Build image for all packages at once, and only distinguish them at runtime?
  • Introduce all needed env vars to the Terraform
  • Document use of .tfvars and .tfbackend

Supporting Docs

@ships ships force-pushed the ships/bootstrap-aws-infrastructure branch from b9d5d0e to b19fd08 Compare February 1, 2024 21:35
Copy link
Member

@kalilsn kalilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review. This looks like a great base to build on, and I think you captured all my feedback in your TODOs anyways. Since these are all additive changes (with the exception of the permission fix on our build script), I think it's fine to address those in future PRs

@ships ships merged commit ce7693c into main Feb 13, 2024
3 checks passed
@ships ships deleted the ships/bootstrap-aws-infrastructure branch February 13, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants