Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage Update and Creation #201

Merged
merged 33 commits into from
Jan 31, 2024
Merged

Stage Update and Creation #201

merged 33 commits into from
Jan 31, 2024

Conversation

qweliant
Copy link
Contributor

@qweliant qweliant commented Dec 13, 2023

Issue(s) Resolved

#190

See context before testing

Test Plan

Reset your local DB
Navigate to this url

First, trying changing the name of a stage and submitting the change.
That should work fine.

Next try removing or adding a move constraint to something:
For instance remove ask for permission from submitted.
You should note ask for submitted gets moved into its own workflow bc it has been disconnected from submitted. It is now its own workflow.

Try reconnecting or removing move constraints and changing the name. Note any unexpected behavior.

Screenshots (if applicable)

Optional

Notes/Context/Gotchas

@eric has mentioned in meetings recently about the notion of viewing how things move through stages as a DAG.

For Instance, Lets say we have nodes A, B, C, D, E:
A-> B, D, E
B-> C, E
C-> D, E

We can build a simple dag

stateDiagram-v2
   [*] --> A
   A --> B
   A --> D
   A --> E
   B --> C
   B --> E
   C --> D
   D --> E
   E --> [*]
Loading

Where the end is some output(our pub filled snowball)

How do we thus visualize a list of stages if some are not connected to any other? How do we visualize workflows that use these nodes when they are a subgraph of our DAG.

For instance, if we add A(1) and A(1) has nothing connecting it to A

stateDiagram-v2
   [*] --> A
   [*] --> A(1)
   A(1) --> D
   A --> B
   A --> D
   A --> E
   B --> C
   B --> E
   C --> D
   D --> E
   E --> [*]
Loading

How do we show one list of of stages
-- (A->B->C-D->E)
and another
-- (A(1)->D->E)

This has not been solved yet, but is very important to keep in mind when testing this PR. If you remove all constraints to and from a stage, it forms its own subgraph, and essentially becomes a root

Supporting Docs

@gabestein gabestein mentioned this pull request Jan 8, 2024
@qweliant qweliant marked this pull request as ready for review January 23, 2024 20:59
@qweliant qweliant requested review from 3mcd, kalilsn and tefkah January 23, 2024 20:59
@qweliant qweliant requested a review from 3mcd January 30, 2024 15:44
@qweliant qweliant merged commit 3da9c0f into main Jan 31, 2024
@qweliant qweliant deleted the qdt/stage-wiring branch January 31, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants