-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stage Update and Creation #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ed36229
to
261ab5e
Compare
3mcd
requested changes
Jan 23, 2024
3mcd
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
#190
See context before testing
Test Plan
Reset your local DB
Navigate to this url
First, trying changing the name of a stage and submitting the change.
That should work fine.
Next try removing or adding a move constraint to something:
For instance remove ask for permission from submitted.
You should note ask for submitted gets moved into its own workflow bc it has been disconnected from submitted. It is now its own workflow.
Try reconnecting or removing move constraints and changing the name. Note any unexpected behavior.
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
@eric has mentioned in meetings recently about the notion of viewing how things move through stages as a DAG.
For Instance, Lets say we have nodes A, B, C, D, E:
A-> B, D, E
B-> C, E
C-> D, E
We can build a simple dag
Where the end is some output(our pub filled snowball)
How do we thus visualize a list of stages if some are not connected to any other? How do we visualize workflows that use these nodes when they are a subgraph of our DAG.
For instance, if we add A(1) and A(1) has nothing connecting it to A
How do we show one list of of stages
--
(A->B->C-D->E)
and another
--
(A(1)->D->E)
This has not been solved yet, but is very important to keep in mind when testing this PR. If you remove all constraints to and from a stage, it forms its own subgraph, and essentially becomes a root
Supporting Docs