chore: PR preview fixes #1021
Merged
chore: PR preview fixes #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalilsn
pushed a commit
that referenced
this pull request
Mar 5, 2025
* chore: set log level=debug * chore: try removing healthcheck * chore: add healthcheck back * chore: attach false maybe * chore: really not sure * chore: try removing minio-init * chore: empty test commit
kalilsn
added a commit
that referenced
this pull request
Mar 5, 2025
* Add ranks to form elements * Add rank to pub values * Set rank for form elements with mudder when creating new forms * Use mudder rank instead of order in form builder * Fix test expectation * Sort pub values by rank * Fix bugs in related value ranking * Fix form builder sort bugs * Pass transaction to getPubType * Fix off by one error * Condense migrations * Set collation order at field level rather than on query * Improve form builder readability * Cleanup * Make keyboard interactions work on sortable form elements * Fix missing hover state on form elements delete/restore buttons * Add test for form element sorting * Set config.label on element creation for proper default label * Actually show label changes in form builder * Set default label correctly for relationship elements * Set correct input component for relationship fields on form creation * Set default config.label when adding a new element to a form * Make sure config.relationshipConfig.component is set for relationship form elements * Update test now that label updates are actually reflected in the form builder * Improve UX for adding relationship form element Clicking edit on a newly added (not saved to the db) field, then clicking cancel will no longer delete the element. That will only happen if you click cancel immediately after adding the new element. The save button in the form element panel will always be enabled when first configuring a new field input element. Previously the only way to add a new relationship field without making an unnecessary config edit was to click the x, since the Save button was disabled and the cancel button would remove the element from the form. * Prevent fallback to bad slug value when rendering unconfigured relationship field * Make sure mudder table in migrations is 0 indexed * chore: PR preview fixes (#1021) * chore: set log level=debug * chore: try removing healthcheck * chore: add healthcheck back * chore: attach false maybe * chore: really not sure * chore: try removing minio-init * chore: empty test commit * Sort get pubs result in js * Fix merge mistake * Add ranks to values in datacite test * Allow tabbing to form element buttons Co-authored-by: Thomas F. K. Jorna <[email protected]> * Fix arcadia seed * Remove unnecessary sorting * Sort pub values in the database * Remove rank from returned values * Update tests to ignore return order of pub values * Update sort test to account for new drag handle setup --------- Co-authored-by: Eric McDaniel <[email protected]> Co-authored-by: Thomas F. K. Jorna <[email protected]>
allisonking
pushed a commit
that referenced
this pull request
Mar 6, 2025
* chore: set log level=debug * chore: try removing healthcheck * chore: add healthcheck back * chore: attach false maybe * chore: really not sure * chore: try removing minio-init * chore: empty test commit
allisonking
pushed a commit
that referenced
this pull request
Mar 6, 2025
* Add ranks to form elements * Add rank to pub values * Set rank for form elements with mudder when creating new forms * Use mudder rank instead of order in form builder * Fix test expectation * Sort pub values by rank * Fix bugs in related value ranking * Fix form builder sort bugs * Pass transaction to getPubType * Fix off by one error * Condense migrations * Set collation order at field level rather than on query * Improve form builder readability * Cleanup * Make keyboard interactions work on sortable form elements * Fix missing hover state on form elements delete/restore buttons * Add test for form element sorting * Set config.label on element creation for proper default label * Actually show label changes in form builder * Set default label correctly for relationship elements * Set correct input component for relationship fields on form creation * Set default config.label when adding a new element to a form * Make sure config.relationshipConfig.component is set for relationship form elements * Update test now that label updates are actually reflected in the form builder * Improve UX for adding relationship form element Clicking edit on a newly added (not saved to the db) field, then clicking cancel will no longer delete the element. That will only happen if you click cancel immediately after adding the new element. The save button in the form element panel will always be enabled when first configuring a new field input element. Previously the only way to add a new relationship field without making an unnecessary config edit was to click the x, since the Save button was disabled and the cancel button would remove the element from the form. * Prevent fallback to bad slug value when rendering unconfigured relationship field * Make sure mudder table in migrations is 0 indexed * chore: PR preview fixes (#1021) * chore: set log level=debug * chore: try removing healthcheck * chore: add healthcheck back * chore: attach false maybe * chore: really not sure * chore: try removing minio-init * chore: empty test commit * Sort get pubs result in js * Fix merge mistake * Add ranks to values in datacite test * Allow tabbing to form element buttons Co-authored-by: Thomas F. K. Jorna <[email protected]> * Fix arcadia seed * Remove unnecessary sorting * Sort pub values in the database * Remove rank from returned values * Update tests to ignore return order of pub values * Update sort test to account for new drag handle setup --------- Co-authored-by: Eric McDaniel <[email protected]> Co-authored-by: Thomas F. K. Jorna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR temporarily disables the minio-init service, which variably returns status code 0 or 1. I'm not sure what the cause is yet, but since file uploads are not working, I'm going to go ahead and merge this to get the preview workflow to report successes.