Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow file-uploads from the server > 5mb #1019

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

tefkah
Copy link
Member

@tefkah tefkah commented Mar 4, 2025

  • fix: update aws sdk version to unbreak large file uploads
  • dev: add tests with large file

Issue(s) Resolved

uploadFileToS3 would fail if filesize > 5mb

High-level Explanation of PR

Version mismatch with s3 client and the multipart fileupload helper library.

Since they introduced this change (aws/aws-sdk-js-v3#6810), it would try to access a checksum method which did not yet exist.

Test Plan

  1. Run tests.
  2. See that the test fails on the previous version. ie, in core, do pnpm i @aws-sdk/[email protected] and do pnpm vitest lib/server/assets.db.test.ts

Screenshots (if applicable)

Notes

@tefkah tefkah requested review from kalilsn, 3mcd and allisonking March 4, 2025 19:05
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked as you said it would!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants