Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR previews #1018

Merged
merged 62 commits into from
Mar 4, 2025
Merged

PR previews #1018

merged 62 commits into from
Mar 4, 2025

Conversation

3mcd
Copy link
Member

@3mcd 3mcd commented Mar 4, 2025

Issue(s) Resolved

N/A

High-level Explanation of PR

This PR adds a deploy-preview step to our on_pr GitHub actions workflow that will, when labeled with a new preview label, deploy the containers produced by the upstream build-all step to temporary AWS Lightsail instances.

The changes are essentially all additive:

  • A new step was added to on_pr that uses the pullpreview action
  • A new docker compose file (docker-compose.preview.yml) containing simple config changes was added. This file is not meant to be used on its own, and instead is merged into the self-host docker compose file, so we're dogfooding our self hosting setup!
  • pullpreview is configured to fetch images from our private ECR repository so we don't need to pollute the public GCR repository with review images

Test Plan

Find the deployment close to the bottom of this page, open it, and confirm the app works!

@3mcd 3mcd added the preview Auto-deploys a preview application label Mar 4, 2025
@github-actions github-actions bot had a problem deploying to gh-654103159-pr-1018 March 4, 2025 18:46 Error
@github-actions github-actions bot had a problem deploying to gh-654103159-pr-1018 March 4, 2025 19:22 Error
@github-actions github-actions bot had a problem deploying to gh-654103159-pr-1018 March 4, 2025 19:40 Error
@3mcd 3mcd merged commit b52f37c into main Mar 4, 2025
5 checks passed
@3mcd 3mcd deleted the em/preview branch March 4, 2025 19:47
@github-actions github-actions bot had a problem deploying to gh-654103159-pr-1018 March 4, 2025 19:51 Error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Auto-deploys a preview application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants