Skip to content

Commit

Permalink
fix deploy workflow: use of overrides
Browse files Browse the repository at this point in the history
  • Loading branch information
ships committed Feb 19, 2024
1 parent d171ec6 commit 15ac42e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/deploy-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:

env:
AWS_REGION: us-east-1
ECR_REPOSITORY: pubpub-v7-${{ inputs.service }}
ECR_REPOSITORY_PREFIX: pubpub-v7
ECS_SERVICE: ${{ inputs.proper-name }}-${{inputs.service}}
ECS_CLUSTER: ${{inputs.proper-name}}-ecs-cluster-${{inputs.environment}}
ECS_TASK_DEFINITION_TEMPLATE: ${{ inputs.proper-name }}-${{inputs.service}}
Expand Down Expand Up @@ -70,10 +70,10 @@ jobs:
id: label
env:
ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
IMAGE_TAG: ${{ steps.gettag.outputs.tag }}
run: |
sha_short=$(git describe --always --abbrev=40 --dirty)
echo "label=$ECR_REGISTRY/$ECR_REPOSITORY_PREFIX-${CONTAINER_NAME}:$sha_short" >> $GITHUB_OUTPUT
echo "base_label=$ECR_REGISTRY/$ECR_REPOSITORY_PREFIX:$sha_short" >> $GITHUB_OUTPUT
echo "label=$ECR_REGISTRY/$ECR_REPOSITORY_PREFIX-${CONTAINER_NAME}:$IMAGE_TAG" >> $GITHUB_OUTPUT
echo "base_label=$ECR_REGISTRY/$ECR_REPOSITORY_PREFIX:$IMAGE_TAG" >> $GITHUB_OUTPUT
- name: Fill in the new image ID in the Amazon ECS task definition
id: task-def-service
Expand Down

0 comments on commit 15ac42e

Please sign in to comment.