Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading PubNub Swift SDK #188

Merged
merged 156 commits into from
Sep 23, 2024
Merged

Upgrading PubNub Swift SDK #188

merged 156 commits into from
Sep 23, 2024

Conversation

jguz-pubnub
Copy link
Contributor

@jguz-pubnub jguz-pubnub commented Sep 10, 2024

feat(module): replace module name with PubNubSDK due to compiler error when a public type shares the same name as the module

feat(subscribe): add new subscriptionChanged(channels, groups) connection status and remove previously deprecated connecting and reconnecting cases

feat(reconnection-policy): remove previously deprecated .legacyExponential(base, scale, maxDelay) reconnection policy

feat(objects): added additional fields to fetch in PubNub.MembershipInclude and PubNub.MemberInclude

feat(configuration): set default AutomaticRetry for retrying subscribe requests with exponential reconnection policy

feat(listeners): add support for attaching additional listeners to Subscription and SubscriptionSet

fix(listeners): ensure that subscriptions are always internally stored as weak references

* Updating README.md
* Updating Package.swift and PubNubSwift.podspec with visionOS target
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are very few questions and concerns in the comments.

Sources/PubNub/APIs/Objects+PubNub.swift Show resolved Hide resolved
Sources/PubNub/APIs/Objects+PubNub.swift Show resolved Hide resolved
Sources/PubNub/KMP/KMPPubNub+History.swift Show resolved Hide resolved
Sources/PubNub/KMP/KMPPubNub+Listeners.swift Outdated Show resolved Hide resolved
Sources/PubNub/KMP/KMPPubNub+Listeners.swift Outdated Show resolved Hide resolved
Sources/PubNub/KMP/KMPPubNub+Push.swift Show resolved Hide resolved
Sources/PubNub/KMP/Wrappers/KMPPresenceChange.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jguz-pubnub
Copy link
Contributor Author

@pubnub-release-bot release as 8.0.0

@jguz-pubnub jguz-pubnub merged commit 7ec9708 into master Sep 23, 2024
10 checks passed
@jguz-pubnub jguz-pubnub deleted the feat/kmp2 branch September 23, 2024 14:00
@pubnub-release-bot
Copy link

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants