-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CryptorModule #144
Merged
Merged
CryptorModule #144
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
78da753
CryptorModule
jguz-pubnub 988f8ae
Contract tests implemented
jguz-pubnub b57f156
Added comments for CryptorHeaderWithinStreamFinder and provides more …
jguz-pubnub 7726ea6
Method for decrypting an InputStream from CryptorModule now takes one…
jguz-pubnub 83ba71f
Prevent from appending CryptorHeader for LegacyCryptor used as an enc…
jguz-pubnub 2cb46f9
CryptorModule
jguz-pubnub e82f02f
Fixes according to review (in progress)
jguz-pubnub c5186ec
Fixes according to review (in progress #2)
jguz-pubnub 71416bc
Fixes
jguz-pubnub 5d2868f
Update Sources/PubNub/Helpers/Crypto/CryptorModule.swift
jguz-pubnub d814f5d
Fixes
jguz-pubnub facc3c4
POC for improving CryptoInputStream and computing output length
jguz-pubnub bdc2c1e
* Provide both cipherKey: and cryptorModule: for the PNConfig constru…
jguz-pubnub 1876e56
* Preserves setting cipherKey for backward compatibility
jguz-pubnub 5d2c954
LICENSE + minor fixes for inline documentation
jguz-pubnub 97bb528
PubNub SDK v6.2.0 release.
pubnub-release-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,4 +19,4 @@ SPEC CHECKSUMS: | |
|
||
PODFILE CHECKSUM: 61a40240486621bb01f596fdd5bc632504940fab | ||
|
||
COCOAPODS: 1.11.3 | ||
COCOAPODS: 1.12.1 |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jguz-pubnub Should we try to be consistent with other cases in class? The class itself already specifies that it will be errors, and the
*Error
suffix won't have much meaning. Other cases which report any troubles have*Failure
suffix.