-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading PubNub Swift SDK #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguz-pubnub
requested review from
parfeon,
wkal-pubnub and
marcin-cebo
as code owners
September 10, 2024 14:49
…SubscribeTransitionTests.swift
* Updating README.md * Updating Package.swift and PubNubSwift.podspec with visionOS target
parfeon
reviewed
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are very few questions and concerns in the comments.
Sources/PubNub/EventEngine/Subscribe/Effects/EmitMessagesEffect.swift
Outdated
Show resolved
Hide resolved
…in the remote * Changes in KMPPresenceChange.swift
parfeon
reviewed
Sep 17, 2024
parfeon
reviewed
Sep 17, 2024
parfeon
reviewed
Sep 18, 2024
parfeon
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@pubnub-release-bot release as 8.0.0 |
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(module): replace module name with
PubNubSDK
due to compiler error when a public type shares the same name as the modulefeat(subscribe): add new
subscriptionChanged(channels, groups)
connection status and remove previously deprecatedconnecting
andreconnecting
casesfeat(reconnection-policy): remove previously deprecated
.legacyExponential(base, scale, maxDelay)
reconnection policyfeat(objects): added additional fields to fetch in
PubNub.MembershipInclude
andPubNub.MemberInclude
feat(configuration): set default
AutomaticRetry
for retrying subscribe requests with exponential reconnection policyfeat(listeners): add support for attaching additional listeners to
Subscription
andSubscriptionSet
fix(listeners): ensure that subscriptions are always internally stored as weak references