Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message type support for: publish, signal, history and subscribe #444

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented Jan 24, 2023

feat(publish): add message type support for publish API

Add new publish parameters to specify messageType and spaceId.

feat(signal): add message type support for signal API

Add new signal parameters to specify messageType and spaceId.

feat(history): add message type support for history API

Make it possible to opt-out message type receive for stored messages and get spaceId for stored message.

Add new publish parameters to specify `messageType` and `spaceId`.

feat(signal): add message type support for `signal` API

Add new signal parameters to specify `messageType` and `spaceId`.

feat(history): add message type support for `history` API

Make it possible to opt-out message type receive for stored messages and get `spaceId` for stored message.
Add new fetch batch history parameters to specify `includeMessageType` and `includeSpaceId`.

feat(subscribe): return message type and space in listener

Objects returned with message / signal listeners now have new `messageType` and `spaceId` fields.
@parfeon parfeon added status: done This issue is considered resolved. priority: medium This PR should be reviewed after all high priority PRs. type: feature This PR contains new feature. labels Jan 24, 2023
@parfeon parfeon requested a review from CraigLn as a code owner January 24, 2023 13:15
@parfeon parfeon self-assigned this Jan 24, 2023
Add `messageType` and `spaceId` to files API endpoints.
Add contract testing for file upload with `messageType` and `spaceId`.
Add prefix to service provided message types.

refactor(files): do not retry publish on 400

Stop file message publish attempts if server returned 400 status code.
Fix `PNMessageType` initialization when user-provided message type is empty.
refactor(message-type): rename `messageType` to `type`

Rename field in responses and request configuration from `messageType` to `type` and update
history endpoint to include flags.
Fix issue with subscribe contract test after field rename.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: feature This PR contains new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants