-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message type support for: publish
, signal
, history
and subscribe
#444
Open
parfeon
wants to merge
11
commits into
master
Choose a base branch
from
feat/add-message-type
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new publish parameters to specify `messageType` and `spaceId`. feat(signal): add message type support for `signal` API Add new signal parameters to specify `messageType` and `spaceId`. feat(history): add message type support for `history` API Make it possible to opt-out message type receive for stored messages and get `spaceId` for stored message.
Add new fetch batch history parameters to specify `includeMessageType` and `includeSpaceId`. feat(subscribe): return message type and space in listener Objects returned with message / signal listeners now have new `messageType` and `spaceId` fields.
parfeon
added
status: done
This issue is considered resolved.
priority: medium
This PR should be reviewed after all high priority PRs.
type: feature
This PR contains new feature.
labels
Jan 24, 2023
CraigLn
approved these changes
Jan 24, 2023
Add `messageType` and `spaceId` to files API endpoints.
Add contract testing for file upload with `messageType` and `spaceId`.
jguz-pubnub
approved these changes
Feb 21, 2023
Add prefix to service provided message types. refactor(files): do not retry publish on 400 Stop file message publish attempts if server returned 400 status code.
Fix `PNMessageType` initialization when user-provided message type is empty.
refactor(message-type): rename `messageType` to `type` Rename field in responses and request configuration from `messageType` to `type` and update history endpoint to include flags.
Fix issue with subscribe contract test after field rename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: medium
This PR should be reviewed after all high priority PRs.
status: done
This issue is considered resolved.
type: feature
This PR contains new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(publish): add message type support for
publish
APIAdd new publish parameters to specify
messageType
andspaceId
.feat(signal): add message type support for
signal
APIAdd new signal parameters to specify
messageType
andspaceId
.feat(history): add message type support for
history
APIMake it possible to opt-out message type receive for stored messages and get
spaceId
for stored message.