Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce userId as uuid replacement #436

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduce userId as uuid replacement #436

wants to merge 1 commit into from

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented Jul 12, 2022

feat: introduce userId as uuid replacement

Introduce new userId configuration (provided to PNConfiguration instance) property which replaces deprecated uuid.

@parfeon
feat: introduce userId as uuid replacement
49afa94 
Introduce new `userId` configuration (provided to `PNConfiguration` instance) property which
replaces deprecated `uuid`.
@parfeon parfeon added status: done This issue is considered resolved. priority: medium This PR should be reviewed after all high priority PRs. type: feature This PR contains new feature. labels Jul 12, 2022
@parfeon parfeon self-assigned this Jul 12, 2022
@parfeon parfeon requested a review from CraigLn as a code owner July 12, 2022 08:02
@parfeon
Copy link
Contributor Author

parfeon commented Jul 12, 2022

@CraigLn this will be part of bigger changes, so it will be better to have it reviewed in portions. When all will be ready, there will be no need to review huge number of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CraigLn CraigLn CraigLn approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@parfeon parfeon

Labels
priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: feature This PR contains new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parfeon @CraigLn