Hard delete returns null instead of last known data
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguz-pubnub
approved these changes
Oct 25, 2024
wkal-pubnub
force-pushed
the
wkal/deletion_return_values
branch
from
d18c50d
to
9052e46
Compare
wkal-pubnub
changed the title
null instead of last know datanull instead of last known data
Previously we diverged by returning the last known version of the data, this reverts it to returning `null` when hard deleting users and channels.
wkal-pubnub
force-pushed
the
wkal/deletion_return_values
branch
from
9052e46
to
dee3766
Compare
|
One JS test keeps failing only on CI, can't get it to fail locally... will investigate, but merging this for the time being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we diverged from TS Chat by returning the last known version of the data, this reverts it to returning
nullwhen hard deleting users and channels.