tools/internal/parser: check TXT records #2213
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports checking a single PR, as well as re-verifying the entire PSL.
Opening as a draft because I forgot about this until now :( and I need to re-read the change to make sure it's ready to go and doesn't have leftover debugging cruft.
The main portion of the change is in validate.go, and is hopefully commented enough to explain what's happening. Essentially, we do parallel DNS lookups to discover the _psl records, gather a list of all PRs to verify, an then fan out again with github API requests to inspect the PRs and see if they match the TXT record.
Note that when running the validation on the entire PSL, or doing frequent reruns, you need a github auth token in the environment as GITHUB_TOKEN, otherwise you'll get rate limited by github pretty much instantly.