ci: update test workflow triggers to include PRs. #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the `test.yml` GitHub workflow's triggers to include `pull_request` in addition to `push`. This will ensure that when a pull request is opened the CI tasks are run and check statuses added to the PR. Without an update to the repository settings to enable branch protection rules these will not be _blocking_ checks.
weppos
approved these changes
Aug 4, 2023
|
Thanks @cpu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates the
test.ymlGitHub workflow's triggers to includepull_requestin addition topush. This will ensure that when a pull request is opened the CI tasks are run and check statuses added to the PR.I overlooked this in my earlier CI cleanup PR and noticed this wasn't happening when I opened #1817.
Without an update to the repository settings to enable branch protection rules (recommended) these will not be blocking checks.