Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 capture softlaunch #732

Merged
merged 3 commits into from
Sep 30, 2021
Merged

V2 capture softlaunch #732

merged 3 commits into from
Sep 30, 2021

Conversation

jywarren
Copy link
Member

@gitpod-io
Copy link

gitpod-io bot commented Sep 28, 2021

jywarren added a commit to publiclab/plots2 that referenced this pull request Sep 28, 2021
@jywarren
update .yarnrc with * for custom path
c7eaad1 
building on yarnpkg/yarn#1684 (comment) and publiclab/spectral-workbench#732
@jywarren jywarren mentioned this pull request Sep 28, 2021
Closed
@jywarren
Copy link
Member Author

Huh...

Error:
NewcaptureTest#test_new_capture_spectrum_page:
NoMethodError: undefined method `unpack1' for nil:NilClass
    app/models/spectrum.rb:301:in `image_from_dataurl'
    app/controllers/spectrums_controller.rb:221:in `create'

bin/rails test test/system/newcapture_test.rb:14

@jywarren
Copy link
Member Author

It looks like we're trying to base64 unpack a nil here...

@jywarren
Copy link
Member Author

OK, these lines added/changed the input for dataurl which resulted in a nil params[:dataurl] being passed to the Rails save action:

publiclab/spectral-workbench.js@49b5796#diff-101249089386c753ed3668bdce872493e5d6724347da2fafe64fd463b03fb94dR164

@jywarren jywarren merged commit 6f61022 into main Sep 30, 2021
@jywarren
Copy link
Member Author

😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jywarren