Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera switching dropdown element addition to /v2 #698

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

waridrox
Copy link
Member

This PR aims to achieve the following -

  • Using adapterjs as a library instead of the CDN script
  • Updating some styles for the interface
  • Adding a dropdown element for the new interface at /v2

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Aug 13, 2021

@waridrox waridrox requested a review from jywarren August 13, 2021 19:11
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! How does this relate to [publiclab/spectral-workbench.js] Camera switching in a dropdown list (#247) though? Thanks!!!!

@waridrox
Copy link
Member Author

Oh I'm not able to get the context of #247 😅, here's the integration in the distributable file - publiclab/spectral-workbench.js#247

@jywarren
Copy link
Member

Aha, i just linked to the wrong one - publiclab/spectral-workbench.js#247 is correct. Thank you!

@jywarren
Copy link
Member

Once conflicts are resolved this is good to go! Thanks!

@jywarren jywarren merged commit edaaa71 into publiclab:main Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants