-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added functionality for downloading spectrum image #245
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4fedbce
Added function for downloading spectrum img
waridrox 4368655
Adding dropdown for camera switching
waridrox 2bd1101
Merge branch 'main' into downloadSpectrum
waridrox 7650ccf
download file and check length
jywarren 692c7b2
Update spectral-workbench-demo.spec.js
jywarren 24d7062
Update spectral-workbench-demo.spec.js
jywarren 1962fa2
Update spectral-workbench-demo.spec.js
jywarren d7834a7
increase file length test for downloaded image
jywarren File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -246,9 +246,14 @@ <h1> | |
</div> | ||
</div> | ||
|
||
<input name="dataurl" type="hidden" id="dataurl" /> | ||
|
||
<button class="demo-button next" id="capture-page-next">Save Capture</button> | ||
<p style="margin-top: 0.5em">Once you save the capture, you cannot go back here.</p> | ||
<img style="display:none;background:#333;" id="spectrum-preview" /> | ||
|
||
<button class="demo-button next" id="download-spectrum" onClick="$W.downloadSpectrum();">Download</button> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. here's the button |
||
|
||
</div> | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome. Is this something we ought to write a test for? It seems like it could be a pretty easy test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, in which file would it make more sense tho 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the test assertion would be to confirm what
a.href
equals.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/waridrox/spectral-workbench.js/blob/downloadSpectrum/cypress/integration/spectral-workbench-demo.spec.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we try using Cypress to press the download button and then assert if
a.href
is not empty? If that doesn't work, then we can try inserting an image to the