Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bootstrap from 4.1.0 to 4.6.2 #11287

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 19, 2022

Bumps bootstrap from 4.1.0 to 4.6.2.

Release notes

Sourced from bootstrap's releases.

v4.6.2

What's changed

There are two big highlights in v4.6.2:

  • First, we've added an example to our Collapse plugin docs to show how to use horizontal collapsing. This has long been possible via our JS, but we never had an official class to utilize it.

  • Second, we've replaced the deprecated color-adjust with print-color-adjust in our Sass files as part of the Autoprefixer v10.4.6 issues. This should quiet the issues folks have seen from that dependency change. If you're using our distribution CSS files, like bootstrap.min.css, you may still see the warning.

Beyond that, we've addressed a few other things:

  • Tweaked the size of small and .small to compute to a whole pixel value (was 12.8px and now is 14px).
  • Improved accessibility around our dropdowns, color contrast, and role attributes.
  • Fixed some broken links to supporting documentation.
  • Updated dependencies across the board.

4.6.1

What's changed

Full changelog

twbs/bootstrap@v4.6.0...v4.6.1

v4.6.0

Highlights

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by xhmikosr, a new releaser for bootstrap since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file JavaScript labels Jul 19, 2022
@gitpod-io
Copy link

gitpod-io bot commented Jul 19, 2022

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-4.6.2 branch from 1e370f2 to 173ed0f Compare July 19, 2022 16:33
@jywarren
Copy link
Member

Odd...

ERROR PostTest#test_awarding_barnstar_functions_correctly (86.56s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find css "input[value='Give']"
            test/system/post_test.rb:248:in `block in <class:PostTest>'

@jywarren
Copy link
Member

Hmm, nothing modal related in https://github.com/twbs/bootstrap/releases/tag/v4.6.0, could just be timing?

@jywarren
Copy link
Member

@dependabot rebase

Bumps [bootstrap](https://github.com/twbs/bootstrap) from 4.1.0 to 4.6.2.
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v4.1.0...v4.6.2)

---
updated-dependencies:
- dependency-name: bootstrap
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-4.6.2 branch from 173ed0f to 17dc0e5 Compare July 19, 2022 16:50
@codeclimate
Copy link

codeclimate bot commented Jul 19, 2022

Code Climate has analyzed commit 17dc0e5 and detected 0 issues on this pull request.

View more on Code Climate.

@jywarren
Copy link
Member

Hmm.

ERROR PostTest#test_awarding_barnstar_functions_correctly ([98](https://github.com/publiclab/plots2/runs/7414454945?check_suite_focus=true#step:9:99).92s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find css "input[value='Give']"
            test/system/post_test.rb:248:in `block in <class:PostTest>'
==[Screenshot]: tmp/screenshots/failures_test_deleting_a_wiki.png
ERROR PostTest#test_deleting_a_wiki (164.34s)
Minitest::UnexpectedError:         Capybara::ModalNotFound: Unable to find modal dialog with All revisions will be lost, and you cannot undo this action. If this is a spam page, be sure that it did not overwrite valid content before deleting the entire page and the history.
            test/system/post_test.rb:234:in `block in <class:PostTest>'
Warning: NING] Unrecognized arguments: google_project, google_json_key_location
/home/runner/work/plots2/plots2/vendor/bundle/ruby/2.7.0/gems/paperclip-6.1.0/lib/paperclip/url_generator.rb:68: warning: URI.escape is obsolete
/home/runner/work/plots2/plots2/vendor/bundle/ruby/2.7.0/gems/paperclip-6.1.0/lib/paperclip/url_generator.rb:68: warning: URI.escape is obsolete
==[Screenshot]: tmp/screenshots/failures_test_following_the_wiki_author.png
ERROR PostTest#test_following_the_wiki_author (290.65s)
Minitest::UnexpectedError:         Capybara::ElementNotFound: Unable to find css ".alert-success"
            test/system/post_test.rb:1[99](https://github.com/publiclab/plots2/runs/7414454945?check_suite_focus=true#step:9:100):in `block in <class:PostTest>'

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 9, 2022

Superseded by #11562.

@dependabot dependabot bot closed this Nov 9, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/bootstrap-4.6.2 branch November 9, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant