fixed the indentation in _nodes.html.erb #11027
Conversation
|
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
|
|
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Hi @TildaDares I have made the changes. @publiclab/reviewers |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
There was a problem hiding this comment.
@mr-funtor Can you take a look at the file again? Some lines aren't indented properly.
@TildaDares please what lines would you like me to adjust? |
|
@mr-funtor From here you can see the lines that need adjustments.
|
@TildaDares thank you for your response. I would make another pull request to reflect the changes. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
@TildaDares I have made the readjustment |
|
@TildaDares I have made the readjustments. |
app/views/spam2/_nodes.html.erb
Outdated
| select_all(); | ||
| }); | ||
|
|
There was a problem hiding this comment.
@mr-funtor Can you remove this empty line? Everything else looks good. Thanks!!
There was a problem hiding this comment.
@TildaDares I have removed the line. Thank you
Codecov Report
@@ Coverage Diff @@
## main #11027 +/- ##
==========================================
- Coverage 82.45% 82.33% -0.12%
==========================================
Files 98 98
Lines 5990 5990
==========================================
- Hits 4939 4932 -7
- Misses 1051 1058 +7
|
|
Code Climate has analyzed commit 927bb5e and detected 0 issues on this pull request. View more on Code Climate. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
|
Congratulations @mr-funtor 🎉 |
@TildaDares Thank you so much 🕺🕺🕺 |
-Adjusted the index to the file to make it more readable.
Fixes #11019
@VictoriaAjala @TildaDares @publiclab/reviewers
Beneath is a screenshot of the previous file before the present change.
https://github.com/publiclab/plots2/suites/6071328877/artifacts/209946595