Fallback to english translation for empty strings (#9974)

* Fallback to english translation for empty strings * Adding spaces * Adding spaces 2 Co-authored-by: imajit <[email protected]>
publiclab · Aug 3, 2021 · a54bf46 · a54bf46
1 parent 93a78b2
commit a54bf46
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
@@ -158,9 +158,10 @@ def translation(key, options = {}, html = true)
     translated_string = t(key, options)
     options[:fallback] = false
     translated_string2 = t(key, options)
+    english_translation = t(key, locale: :en)
 
-    if html && current_user&.has_tag('translation-helper') && translated_string2.include?("translation missing") && !translated_string.include?("<")
-      raw(%(<span>#{translated_string} <a class="translationIcon" style='display: none; padding-left: 3px;' href="https://www.transifex.com/publiclab/publiclaborg/translate/#de/$?q=text%3A#{translated_string}">
+    if html && current_user&.has_tag('translation-helper') && (translated_string2.include?("translation missing") || translated_string === "") && !translated_string.include?("<")
+      raw(%(<span>#{english_translation} <a class="translationIcon" style='display: none; padding-left: 3px;' href="https://www.transifex.com/publiclab/publiclaborg/translate/#de/$?q=text%3A#{translated_string}">
           <i data-toggle='tooltip' data-placement='top' title='Needs translation? Click to help translate the text \" #{translated_string} \" .' style='position:relative; right:2px; color:#bbb; font-size: 15px;' class='fa fa-globe'></i></a>
        </span>))
     else