Robin natale robin #391 #429
Conversation
Step 1 completed
| @@ -1,4 +1,4 @@ | |||
| Contributing to Leaflet Environmental Layers | |||
| Robin Contributing to Leaflet Environmental Layers | |||
There was a problem hiding this comment.
Is there a reason you added your name here?
| @@ -0,0 +1,545 @@ | |||
| require('jquery'); | |||
There was a problem hiding this comment.
I am curious as to why it looks like all the lines were added. May I know the steps you took to make this PR? Thanks!
There was a problem hiding this comment.
Ah! I see that you created a new layercode.js file and added it to the root. The changes need to be added to the file in the src folder.
| @@ -0,0 +1,545 @@ | |||
| require('jquery'); | |||
There was a problem hiding this comment.
Ah! I see that you created a new layercode.js file and added it to the root. The changes need to be added to the file in the src folder.
|
Hey @crisner I was actually just trying to see if the git push request was working that’s why I initially added my name there. I think I did not realise that the file moved back to the root. I will move to the src folder as soon I get on hold of my laptop 🙏 |
Fixes #391 (<=== Add issue number here)
Please note that step 2 is missing as there were some differences in the code.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!