Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for recent contributors' list #238

Merged
merged 1 commit into from
Aug 3, 2019

Conversation

Rishabh570
Copy link
Collaborator

Fixes #202
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@Rishabh570
Copy link
Collaborator Author

@publiclab/reviewers @jywarren @gauravano Work regarding this PR is almost done, please take a look.

filter

@Rishabh570 Rishabh570 changed the title [WIP] Add filter for recent contributors' list Add filter for recent contributors' list Jul 24, 2019
@Rishabh570
Copy link
Collaborator Author

@gauravano @publiclab/reviewers This work is complete and updated, please take a look...

@Rishabh570
Copy link
Collaborator Author

This is working as expected now, updated and pushed. Please take a look,

filter_done

@jywarren
Copy link
Member

jywarren commented Aug 3, 2019

This is awesome work. Great job! Go ahead and merge it! 🎉 🎉 🎂

@jywarren
Copy link
Member

jywarren commented Aug 3, 2019

Some of these util functions may be great candidates for unit tests, too! Maybe as a follow-up?

@Rishabh570
Copy link
Collaborator Author

@jywarren Yes, so now I'll start adding documentation and unit tests for small pieces of code and the few remaining features will go side-by-side.

Thanks! 😄

@Rishabh570 Rishabh570 merged commit fd36b6a into publiclab:main Aug 3, 2019
TildaDares pushed a commit to TildaDares/community-toolbox that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filter button for recent contributors' list
2 participants