Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user workflow for documenting bugs #530

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

Shulammite-Aso
Copy link
Collaborator

@Shulammite-Aso Shulammite-Aso commented Jun 11, 2020

Fixes #509
The button before the ple-footer is a link that takes a user to the editor-bug-report template here https://publiclab.org/post?n=23853&title=Give%20this%20bug%20a%20title%20here

Screenshot from 2020-06-15 19-34-42

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@Shulammite-Aso Shulammite-Aso changed the title [WIP]Add user workflow for documenting bugs Add user workflow for documenting bugs Jun 15, 2020
@Shulammite-Aso Shulammite-Aso changed the base branch from master to main June 16, 2020 18:37
@Shulammite-Aso
Copy link
Collaborator Author

@jywarren @emilyashley @shreyaa-sharmaa @keshav234156 @NitinBhasneria please take a look at this.

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for repointing this at the main branch! Just a couple small tweaks, thanks!

dist/PublicLab.Editor.js Outdated Show resolved Hide resolved
examples/index.html Outdated Show resolved Hide resolved
@Shulammite-Aso
Copy link
Collaborator Author

Have made the changes @jywarren

@govindgoel
Copy link
Member

Looks Fine!
@jywarren please review this

@jywarren
Copy link
Member

This looks perfect. Thank you so much @Shulammite-Aso !!!

Just checking if you saw this post on the release schedule: #532 (comment)

just want to be sure you're in sync, thank you!

@jywarren jywarren merged commit 1a5fe70 into publiclab:main Jun 23, 2020
@jywarren
Copy link
Member

Done! Great! So, i think we need to be sure this gets reflected not just in the example but in the plots2 usage as well. The corresponding file in the plots2 integration is here:

https://github.com/publiclab/plots2/blob/master/app/views/editor/rich.html.erb

Can you open a new PR on plots2 making the same change (probably the CSS won't be needed if we ensure that a new release of the Editor is merged before this change is added? Or we can just redundantly add the CSS change to plots2 but leave a comment that it can be removed after the next version of the Editor.

Thank you @Shulammite-Aso ! It'll be great to see this in production!

@Shulammite-Aso
Copy link
Collaborator Author

Done! Great! So, i think we need to be sure this gets reflected not just in the example but in the plots2 usage as well. The corresponding file in the plots2 integration is here:

https://github.com/publiclab/plots2/blob/master/app/views/editor/rich.html.erb

Can you open a new PR on plots2 making the same change (probably the CSS won't be needed if we ensure that a new release of the Editor is merged before this change is added? Or we can just redundantly add the CSS change to plots2 but leave a comment that it can be removed after the next version of the Editor.

Thank you @Shulammite-Aso ! It'll be great to see this in production!

Oh yeah, will certainly do this.
Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User workflow for documenting bugs.
3 participants