-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the missing closing body tags to export.html and select.html #1227
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! |
hi @abba-danmusa , could you please add the link to the issue you are fixing with this PR |
Sure.
…Sent from my iPhone
On 24 Oct 2022, at 1:42 PM, Cess ***@***.***> wrote:
hi @abba-danmusa , could you please add the link to the issue you are fixing with this PR
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
This is the link to the issue #1218 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abba-danmusa could you please check your changes? it seems you touched lines that were not part of the issue
Okay. Am on it |
Fixed |
Hi cesswairimu, can you please approve this? |
hi @abba-danmusa, I am sorry, it seems the issue you are solving was fixed on this pull request #1247 |
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!