Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT PR: Press page #178

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

DRAFT PR: Press page #178

wants to merge 16 commits into from

Conversation

ElenaFdR
Copy link
Member

@ElenaFdR ElenaFdR commented Mar 8, 2021 •
edited
Loading

This fixes #52.

Still to do:

  • unbreak SVG
  • doublecheck list
  • smoother copy

View rendered press.md

@ElenaFdR ElenaFdR changed the title Press DRAFT PR: Press page Mar 8, 2021
@ElenaFdR ElenaFdR marked this pull request as draft March 8, 2021 16:04
@ElenaFdR
Copy link
Member Author

ElenaFdR commented Mar 9, 2021 •
edited
Loading

@angelplasma suggestions:

  • translate quotation into English
  • set expectation re paywalls
  • remove the chronological framing (to make more evergreen) (don't include the date?)
  • make more visual: add header images, or publication logos?
  • longer page discourages clicking through (bring more content on one page, including extended excerpts), whereas if we want people to click through, make it more compact (possibly even all on 1 screen)

@ElenaFdR ElenaFdR mentioned this pull request Mar 22, 2021
Merged
@ElenaFdR ElenaFdR marked this pull request as ready for review July 6, 2021 20:27
bvhme
bvhme requested changes Dec 14, 2021
View reviewed changes
Copy link
Member

@bvhme bvhme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content!

The HTML misses some closing tags and structural elements and will break the layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvhme bvhme bvhme requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create page for press about us (publiccode.net/press)
3 participants
@ElenaFdR @bvhme @angelplasma