Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple fixes of different importance #333

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: multiple fixes of different importance #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bfb2a57
redundancy
crStiv Dec 20, 2024
20a6b76
typo
crStiv Dec 20, 2024
97252fa
typo
crStiv Dec 20, 2024
8c5ff5f
typo
crStiv Dec 20, 2024
68cce15
typos
crStiv Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/marketplace/src/execute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1286,7 +1286,7 @@ fn store_ask(store: &mut dyn Storage, ask: &Ask) -> StdResult<()> {
asks().save(store, ask_key(&ask.collection, ask.token_id), ask)
}

/// Checks to enfore only NFT owner can call
/// Checks to enforce only NFT owner can call
fn only_owner(
deps: Deps,
info: &MessageInfo,
Expand Down
6 changes: 3 additions & 3 deletions contracts/marketplace/src/helpers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ mod tests {
#[test]
fn test_map_validate() {
let deps = mock_dependencies();
let adddreses = map_validate(
let addresses = map_validate(
&deps.api,
&[
"operator1".to_string(),
Expand All @@ -94,7 +94,7 @@ mod tests {
.unwrap();
assert_eq!(3, adddreses.len());

let adddreses = map_validate(
let addresses = map_validate(
&deps.api,
&[
"operator1".to_string(),
Expand All @@ -107,7 +107,7 @@ mod tests {
.unwrap();

assert_eq!(
adddreses,
addresses,
vec![
Addr::unchecked("operator1".to_string()),
Addr::unchecked("operator2".to_string()),
Expand Down
4 changes: 2 additions & 2 deletions contracts/marketplace/src/testing/tests/admin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ fn try_start_trading_time() {
.unwrap();
assert_eq!(res.owner, bidder.to_string());

// Creator tries to accept accept bid on collection 2 (should fail)
// Creator tries to accept bid on collection 2 (should fail)
let accept_bid_msg = ExecuteMsg::AcceptCollectionBid {
collection: collection_2.to_string(),
token_id: minter_2_token_id_0,
Expand Down Expand Up @@ -340,7 +340,7 @@ fn try_start_trading_time() {
// move time to start trading time
setup_block_time(&mut router, start_time.plus_seconds(1).nanos(), None);

// Creator tries to accept accept bid on collection 2 should work now
// Creator tries to accept bid on collection 2 should work now
let accept_bid_msg = ExecuteMsg::AcceptBid {
collection: collection_2.to_string(),
token_id: minter_2_token_id_0,
Expand Down
2 changes: 1 addition & 1 deletion contracts/marketplace/src/testing/tests/asks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1277,7 +1277,7 @@ fn try_sync_ask() {
.unwrap();
assert_eq!(res.asks.len(), 0);

// Approving again should have a success sync ask after
// Approving again should have a successful sync ask after
approve(&mut router, &creator, &collection, &marketplace, token_id);

// SyncAsk should be ok
Expand Down
2 changes: 1 addition & 1 deletion contracts/marketplace/src/testing/tests/finders_fee_and_royalties.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ fn try_zero_royalties() {
bidder_native_balances,
coins(INITIAL_BALANCE - 100, NATIVE_DENOM)
);
// seller should recive full amount minus fairburn (2%)
// seller should receive full amount minus fairburn (2%)
let minter_balance = router.wrap().query_all_balances(minter.clone()).unwrap();
assert_eq!(
minter_balance,
Expand Down