BE-239 - Include mint price denom among mint event attributes for minter-wl-flex #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MightOfOaks
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 60.07% 60.07%
=======================================
Files 83 83
Lines 4518 4518
=======================================
Hits 2714 2714
Misses 1804 1804 ☔ View full report in Codecov by Sentry. |
Cosm-Orc Gas Usage
Raw Report for b9c81d1
|
jhernandezb
requested changes
Dec 13, 2023
| .add_attribute("seller_amount", seller_amount)) | ||
| .add_attribute( | ||
| "network_fee", | ||
| coin(network_fee.u128(), mint_price.clone().denom).to_string(), |
There was a problem hiding this comment.
I don't think we need to change network fee if it is a coin already the to_string() implementation should be including amount and denom
There was a problem hiding this comment.
network_fee is only a Uint128 here I am afraid.
| .add_attribute("mint_price", mint_price.to_string()) | ||
| .add_attribute( | ||
| "seller_amount", | ||
| coin(seller_amount.u128(), mint_price.denom).to_string(), |
There was a problem hiding this comment.
same here no need to do coin(..) again
There was a problem hiding this comment.
Same for seller_amount, it's a Uint128.
| "network_fee", | ||
| coin(network_fee.u128(), mint_price.clone().denom).to_string(), | ||
| ) | ||
| .add_attribute("mint_price", mint_price.to_string()) |
There was a problem hiding this comment.
this looks good although not sure if to_string is necessary
There was a problem hiding this comment.
Receiving a the trait From<Coin> is not implemented for std::string::String error otherwise.
tasiov
approved these changes
Dec 13, 2023
jhernandezb
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.