Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token URI scheme as init arg #627

Closed
wants to merge 4 commits into from

Conversation

dgabriele
Copy link

No description provided.

@dgabriele dgabriele marked this pull request as ready for review November 27, 2023 00:42
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (f4f6e82) 60.07% compared to head (8b0e3b4) 60.00%.

❗ Current head 8b0e3b4 differs from pull request most recent head 9d558e2. Consider uploading reports for the commit 9d558e2 to get more accurate results

Files Patch % Lines
...cts/minters/vending-minter-wl-flex/src/contract.rs 0.00% 7 Missing ⚠️
...tracts/minters/open-edition-minter/src/contract.rs 50.00% 4 Missing ⚠️
contracts/minters/base-minter/src/contract.rs 60.00% 2 Missing ⚠️
contracts/minters/vending-minter/src/contract.rs 71.42% 2 Missing ⚠️
...up/setup_minter/open_edition_minter/mock_params.rs 33.33% 2 Missing ⚠️
e2e/src/helpers/helper.rs 0.00% 1 Missing ⚠️
e2e/src/helpers/open_edition_minter_helpers.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
- Coverage   60.07%   60.00%   -0.07%     
==========================================
  Files          83       83              
  Lines        4518     4536      +18     
==========================================
+ Hits         2714     2722       +8     
- Misses       1804     1814      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanev shanev requested review from tasiov and jhernandezb January 21, 2024 20:35
Copy link
Member

@shanev shanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes Launchpad more flexible.

Copy link
Member

@shanev shanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we can update this to not even store the URL scheme in the factory. We can remove the URL check altogether to give creators more freedom. Frontend clients can display the URL to inform the user about the type of storage.

@jhernandezb
Copy link
Member

closing in favor of #643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants