-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token URI scheme as init arg #627
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
- Coverage 60.07% 60.00% -0.07%
==========================================
Files 83 83
Lines 4518 4536 +18
==========================================
+ Hits 2714 2722 +8
- Misses 1804 1814 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, makes Launchpad more flexible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we can update this to not even store the URL scheme in the factory. We can remove the URL check altogether to give creators more freedom. Frontend clients can display the URL to inform the user about the type of storage.
closing in favor of #643 |
No description provided.