Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minter updates #622

Merged
merged 3 commits into from
Oct 11, 2023
Merged

minter updates #622

merged 3 commits into from
Oct 11, 2023

Conversation

jhernandezb
Copy link
Member

  • Add more attributes to collection creation
  • Fixed airdrop denominated in different coin than mint_price

@jhernandezb jhernandezb requested review from tasiov, shanev, jason-c-child and MightOfOaks and removed request for tasiov October 11, 2023 18:01
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e2cb431) 60.09% compared to head (2167f21) 60.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   60.09%   60.07%   -0.03%     
==========================================
  Files          83       83              
  Lines        4511     4518       +7     
==========================================
+ Hits         2711     2714       +3     
- Misses       1800     1804       +4     
Files Coverage Δ
contracts/collections/sg721-base/src/contract.rs 61.13% <100.00%> (+0.47%) ⬆️
contracts/minters/vending-minter/src/contract.rs 85.35% <100.00%> (ø)
...cts/minters/vending-minter-wl-flex/src/contract.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Cosm-Orc Gas Usage

Contract Op Name Gas Used Old Gas Used Gas Diff File
multiple_contracts Execute__minter_batch_exec_mint_token 1585000 18815480 -91.5761% e2e/src/tests/open_edition_minter_executes_tests.rs:142
multiple_contracts Execute__minter_batch_exec_mint_token_w_trading_time 1937915 3108721 -37.6620% e2e/src/tests/factory_test.rs:314
vending_minter_wl_flex Store__Store 9037322 8937755 +1.1140% e2e/src/helpers/chain.rs:78
Raw Report for 2167f21
Contract Op Name Gas Used Gas Wanted File
multiple_contracts Execute__minter_batch_exec_mint_token 1585000 2354625 e2e/src/tests/open_edition_minter_executes_tests.rs:142
multiple_contracts Execute__minter_batch_exec_mint_token_w_trading_time 1937915 2893485 e2e/src/tests/factory_test.rs:314
vending_factory Execute__factory_exec_minter_inst 34038023 51033821 e2e/src/tests/factory_test.rs:98
vending_factory Instantiate__factory_inst 187313 257853 e2e/src/helpers/helper.rs:35
vending_factory Store__Store 3067318 4577837 e2e/src/helpers/chain.rs:78
vending_factory Execute__factory_exec_minter_inst_w_trading_time 3858229 5764142 e2e/src/tests/factory_test.rs:244
open_edition_factory Execute__factory_exec_minter_inst_w_trading_time 542975 791337 e2e/src/tests/open_edition_factory_and_mint_tests.rs:405
open_edition_factory Instantiate__factory_inst 186625 256820 e2e/src/helpers/open_edition_minter_helpers.rs:39
open_edition_factory Execute__factory_exec_minter_inst 542264 790272 e2e/src/tests/open_edition_minter_executes_tests.rs:59
open_edition_factory Store__Store 3471462 5184053 e2e/src/helpers/chain.rs:78
base_factory Store__Store 2688056 4008944 e2e/src/helpers/chain.rs:78
base_minter Store__Store 7008685 10489827 e2e/src/helpers/chain.rs:78
open_edition_minter Store__Store 8508482 12739523 e2e/src/helpers/chain.rs:78
sg721_base Store__Store 8395174 12569561 e2e/src/helpers/chain.rs:78
sg721_metadata_onchain Store__Store 8824564 13213646 e2e/src/helpers/chain.rs:78
sg721_nt Store__Store 7794873 11669109 e2e/src/helpers/chain.rs:78
sg721_updatable Store__Store 9181323 13748784 e2e/src/helpers/chain.rs:78
sg_whitelist Store__Store 3609906 5391714 e2e/src/helpers/chain.rs:78
sg_whitelist_flex Store__Store 3539283 5285784 e2e/src/helpers/chain.rs:78
vending_minter Store__Store 8839098 13235447 e2e/src/helpers/chain.rs:78
vending_minter_wl_flex Store__Store 9037322 13532783 e2e/src/helpers/chain.rs:78
whitelist_immutable Store__Store 2197332 3272858 e2e/src/helpers/chain.rs:78
minter Execute__minter_exec_mint_to_token 364018 522905 e2e/src/tests/open_edition_minter_executes_tests.rs:180
minter Execute__minter_exec_purge 139026 185472 e2e/src/tests/open_edition_minter_executes_tests.rs:281
minter Execute__minter_exec_update_per_addr_limit 209177 290648 e2e/src/tests/open_edition_minter_executes_tests.rs:216
minter Execute__minter_exec_update_trading_time 271334 383880 e2e/src/tests/open_edition_minter_executes_tests.rs:99

@jhernandezb jhernandezb merged commit 31190a8 into main Oct 11, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants