Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix foundationdb premium task #6876

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Conversation

nickchomey
Copy link
Contributor

FIxing the premium task for upgrading node-foundationdb to v2.0.1.

Local testing suggests that the only thing that is necessary is installing foundationdb client and server v7.3.xx. You can then specify any apiVersion except 730.

Ive opened an issue at node-foundationdb about this josephg/node-foundationdb#85

Hopefully the tests will pass with this PR

@nickchomey
Copy link
Contributor Author

nickchomey commented Feb 18, 2025

Looks like there aren't automated tests when submitting a PR? How can we get them to run? Or do you just need to pull this PR branch and run the tests yourself to confirm?

@pubkey
Copy link
Owner

pubkey commented Feb 18, 2025

I have to manually trigger them until one of your PRs has been merged.

@nickchomey
Copy link
Contributor Author

Ok, wait til I can try something else out that someone suggested in the issue I opened in node-foundationdb. I'll let you know when ready

@nickchomey
Copy link
Contributor Author

nickchomey commented Feb 18, 2025

Oh nevermind, i see you already ran them and they passed. Still, Id like to explore this a bit deeper. Might end up with a PR to node-foundationdb - it's doing some weird stuff with versions (eg we should be passing apiVersion 730 rather than 720, but it doesn't work like that). I think it's just an oversight though.

@nickchomey
Copy link
Contributor Author

nickchomey commented Feb 18, 2025

Ok, I've tested the bugfix and submitted a small PR to node-foundationdb. For now, we just have to specify an apiVersion of 720 or below. If/when that gets merged, we'll be able to specify 730, which corresponds with the fdb version that we are (should be) using.

I've updated the rx-storage-foundationdb docs-src with guidance. When I run npm run docs:build, it changes ~180 html files, so not sure that I should be doing that. Let me know what you would like

@pubkey pubkey merged commit 66babde into pubkey:master Feb 21, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants