Fix sentence scoring logic considering cases #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when there are multiple clusters in a sentence with higher score value on the prior one.
|
Any comment on the change set? |
| @@ -569,22 +569,26 @@ | |||
| " pos_tagged_tokens = [token for sent in pos_tagged_tokens for token in sent]\n", | |||
| "\n", | |||
| " all_entity_chunks = []\n", | |||
| " previous_pos = None\n", | |||
| " current_status = 'None-NN'\n", | |||
There was a problem hiding this comment.
I apologize for taking so long to merge in this change. I'm just not totally sure where you're going with this second part of the diff where you are materializing current_status. Can you explain what's going on here?
|
Yes, just left you a request for comment so I can more carefully review part of the diff. Sorry it's taking me so long to get this merged in, but I hope to merge it as soon as I hear back from you and read the code through one more time. On May 13, 2014, at 3:15 AM, Ku Bong Min [email protected] wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when there are multiple clusters in a sentence
with higher score value on the prior one.
Additionally, I also modified entity choosing logic to include last NN word in the sentence.