Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're loading entrypoints as modules, exit codes no longer propagate in the same way. Therefore, we must do that explicitly through the system exit function.
Without this the exit code is always ZERO and in practical terms all CI pipelines depending on this are always passing even when the tests are actually failing.
See 7825a0c.
To reproduce:
Build latest jasmine-gjs from master (c6aa28b).
Use the following sample test.
With out this PR the exit code is always ZERO.