Make use as subproject easier #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that tests are loaded as modules, we can use `imports.meta.url` to resolve the path to fixtures instead of passing the directory in the environment.
We variables we currently substitute allow setting up imports when running installed, but need a separate code path for the uninstalled case. Using slightly different variables will allow us to change that.
Instead of using a completely different code path for setting up imports, override only the substituted variables from the environment.
Projects that include jasmine-gjs as subproject want to test their own code, not jasmine-gjs.
Projects that include jasmine-gjs as subproject will typically use it to run their own test suite with `meson test`, which means that jasmine-gjs only runs from the build directory. There is therefore little use for installing jasmine alongside the project. In fact, it can cause problems for packagers when multiple projects end up installing their own copy. Avoid this and simply don't install anything when used as subproject.
If a project includes jasmine-gjs as subproject for its test suite, it currently needs to pass a couple of environment variables for jasmine to work uninstalled. Now that we no longer install anything when used as subproject, we can instead use the right substitutions, so projects can use jasmine in their test suite without special-casing the subproject case.
ptomato
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is possible to use jasmine-gjs as meson subproject after
commit 6fbd6d8, there are a couple of issues with it:
JASMINE_UNINSTALLEDand friends, but only whenfalling back to the subproject
Address those by special-casing the use in a subproject, and
The first two seem pretty common for build dependencies (gi-docgen,
blueprint-compiler). Doing the same for a test dependency doesn't
seem too far fetched.