Move to and support ESM #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last release before 4.0 introduced major changes, including a dependency on addEventListener()/removeEventLister(). Let's worry about that another day, it's already a worthy update.
globalThis was introduced in 1.64, which had only been released a couple of months before the original switch. There are good reasons to not depend on such a recent version, however the release is now almost 4 years old, so the dependency should be unproblematic. This reverts commit ab197b0.
It's already provided by gjs nowadays, and has been for nearly two years.
We'll need this eventually to port the code base to ESM. However it doesn't hurt loading jasmine/runner as modules right now, and it gives us access to toplevel await, which will help with the port.
When we move to modules, we will need more control over the mainloop than we get from the legacy Mainloop module. To prepare for that, let the Command module create its own GLib.MainLoop, and expose it to the test that needs it.
Using a blocking run() call is dangerous, as it will prevent any promises that were previously added to the implicit mainloop from resolving. gjs provides runAsync() overrides that avoid this issue, switch to that for driving the mainloop.
While this is a bit artificial for specs that are imported as scripts, it prepares us for dynamically importing specs as modules, which is always asynchronous.
Add a new `--module` command line flag to import a spec as module instead of a script. This allows creating specs that test exports from modules without having to jump through hoops to import everything dynamically. (I would have gone with `-m` like gjs, but the parser currently doesn't handle short options)
Some test depend on overriding the function, which will no longer work when we move to ESM (where imports are always read-only). Prepare for that by moving the function into an "indenter" object, where it can still be modified after the ESM port.
Now that we support loading specs as modules, we can move away from legacy imports without breaking our own test suite. We still use a legacy import for the upstream jasmine library and a test case of legacy imports, everything else is loaded as module.
ptomato
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for loading specs as modules, so specs can test modules without the need for dynamic imports.
With that in place, the code base itself can be ported to ESM, so do that as well.