Fix include paths being passed to subprocess #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have any short options, but if they are given, they should still not be treated as files. This was masking a bug where the -I include option for GJS was being given in the wrong place.
The include paths were being interpreted as spec paths because the -I was in the wrong place on the command line. In order to prevent this confusion, don't use the -I argument at all (it is weird, and is intercepted by GJS before arg parsing) and instead pass include paths to the subprocess using the GJS_PATH environment variable. Closes: #37
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously include paths in the config file were treated as spec paths.
Closes: #37