-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to jasmine-2.3.4 #38
Conversation
This was my first go (before bed 😉). Below is the reject patch snippets, I'm not sure why those were there so advice would be welcome.
--- jasmine.js 2017-02-07 17:19:05.530588235 -0800
+++ jasmine.js 2017-02-07 17:06:36.825849025 -0800
@@ -689,12 +696,6 @@
runnableLookupTable[suite.id] = suite;
return suite;
-
- function suiteStarted(suite) {
- currentlyExecutingSuites.push(suite);
- defaultResourcesForRunnable(suite.id, suite.parentSuite.id);
- reporter.suiteStarted(suite.result);
- }
};
this.describe = function(description, specDefinitions) {
@@ -1106,8 +1107,6 @@
}
};
- return self;
-
function legacyIE() {
//if these methods are polyfilled, apply will be present
return !(realTimingFunctions.setTimeout || realTimingFunctions.setInterval).apply;
@@ -3055,5 +3058,5 @@
};
getJasmineRequireObj().version = function() {
- return '2.2.0';
+ return '2.2.1';
}; |
46ac9fc
to
e77ba01
Compare
I've made the 2.3.0 release and updated the release checklist so it's actually correct now, so have at it! |
d16ac57
to
ff7dc47
Compare
This is the latest patch release from the 2.3.x series
ff7dc47
to
e730692
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is the latest patch release from the 2.3.4 series