Bug sweep #35
Merged
Bug sweep #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
force-pushed
the
11-handle-search-paths
branch
from
c5a8203 to
2603643
Compare
The importer will cache imports with the same name, so we need to make a fresh copy of the importer with `imports['.']` each time we load a spec file, in case it has the same name as a preceding spec file. Closes: #11
ptomato
force-pushed
the
11-handle-search-paths
branch
from
2603643 to
39c754c
Compare
ptomato
changed the title
Avoid bailing out when using the importer to read in a spec file, if it has a syntax error. Instead, add a suite and an always-failing spec that highlights the location of the syntax error. (Previously, an unhelpful error message would be printed, showing the stack trace of where the spec was imported, not the location of the syntax error within the spec.) Closes: #13
ptomato
force-pushed
the
11-handle-search-paths
branch
from
39c754c to
a161e64
Compare
Previously, a nonexistent spec file was ignored, but this can mask a bug in the build system: you could be passing the wrong paths and not realize it because no tests failed. Instead, add a suite and an always-failing spec if the spec file can't be imported due to it not existing. Closes: #26
ptomato
force-pushed
the
11-handle-search-paths
branch
from
a161e64 to
19368d8
Compare
This may be useful for testing a new version of GJS, or for executing gnome-shell tests that need to load additional libraries first. Closes: #14
ptomato
force-pushed
the
11-handle-search-paths
branch
from
19368d8 to
a6e2272
Compare
andyholmes
reviewed
Aug 24, 2020
ptomato
force-pushed
the
11-handle-search-paths
branch
from
a6e2272 to
9f02a56
Compare
The default debugger is 'gdb --args', but others can be specified. Closes: #16
ptomato
force-pushed
the
11-handle-search-paths
branch
from
9f02a56 to
e045e0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11
Closes: #13
Closes: #14
Closes: #16
Closes: #26