Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit code #25

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Fix exit code #25

merged 2 commits into from
Nov 21, 2017

Conversation

ptomato
Copy link
Owner

@ptomato ptomato commented Nov 21, 2017

Fixes #23.

This was ignoring the 'success' parameter of the 'complete' signal and
instead testing the truth value of the reporter object.

#23
System.exit() seems to still be problematic if called from within a
signal handler. Instead, use an exitCode variable which all the signal
handlers close over, and quit the main loop instead of exiting.

#23
@ptomato ptomato merged commit 7c3de77 into master Nov 21, 2017
@ptomato ptomato deleted the issue/23 branch November 21, 2017 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant