Allow react-native-macos package.json shims #145
Merged
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it possible to add a `react-native-macos` field to package.json that functions the same way as `react-native` to shim one-level deep requires/imports. See facebook/react-native#5917 for details of `browser` and `react-native fields`. This commit makes it possible to share code more broadly between react native platforms. For example, take the following package.json field: ``` "react-native-macos": { "react-native": "react-native-macos" } ``` With this set our components can import from react-native rather than react-native-macos, allowing code sharing between react native platforms more easily.
ptmt
approved these changes
Feb 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it possible to share code more broadly between react native platforms. For example, take the following package.json field:
package.json
With this set our components can import from react-native rather than react-native-macos, allowing code sharing between react native platforms more easily.
Having the ability to use the same imports across platforms is incredibly important. Using the
browserorreact-nativefields of package.json is the accepted way by the community to shim global requires (it's the only way that the React packager accepts shims). The React Native Web project uses a webpack alias to make it possible to use React Native code to target the web without modification.The new
react-native-macosfield in package.json that functions the same way asreact-nativeto shim one-level deep requires/imports. See facebook/react-native#5917 for details ofbrowserandreact-nativefields.I've tested this locally myself and it works fine. I've tried to keep the same rules in this commit, simply adding react native macos as the highest precedence for shimming.