-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assign elements a stacking layer #106
Open
benptc
wants to merge
508
commits into
main
Choose a base branch
from
stacking-order
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when menubar is added, set screenTopOffset to its height
… work on exact position/angle/smoothing of camera in each perspective
… perspectives for third person follows
…rspective, as a function of distanceToCamera
…oded virtualizer id
Virtualizer Camera Following
adds MenuBar item to toggle DarkMode on/off (defaults to dark mode)
recalculates projection matrix when onWindowResized is triggered
Proudly presenting the new remote operator off-center camera: 1. RMB on the AreaTarget adds a "focus point" green cube, and camera rotates around this off-center focus point 2. MMB pan function remains unchanged 3. Mouse wheel scroll zooms the camera towards the focus point 4. Press G to instantly zoom & focus on the focus point
* Added toggle to render human poses in remote viewer. * Tweaked naming in View menu.
1. Clamped the camera vertical angle, so that when camera gets closer to 2 poles, it rotates very slow and never gets to 90 deg. 2. Removed the addButKeepDistance(), since orbit() works well on its own. 3. Pushed the PR in userinterface that exports realityEditor.spatialCursor.getRaycastCoordinates. 4. Deleted the cameraTargetIcon three.js cube, and replaced it with an object with just a visible property. Since we have focusTargetCube now. 5. Added back the rotate / pan / zoom icons. 6. When initializing, adds the focusTargetCube at (0,0,0). 7. reset() function now also resets focusTargetCube back to (0,0,0). 8. Deleted the "prevents camera singularities by slowing down camera movement exponentially as the vertical viewing angle approaches top or bottom" part, since all the rotation clamp vertical angle logic is handled within the rotate section.
…-Off-Center-Camera
Thanks Dan for the suggestions🙏
…nter camera system
Works in conjunction with the new PR in userinterface
1. Fixed the zooming bug so that: when zooming in, camera points towards focus point quicker to avoid getting to the back of the mesh sometimes; when zooming out, no more weird rotating actions 2. Added G-focus keyboard prompt to normal & fly modes
default view frustum cutouts to disabled; toggle in View menu turns on frustum cutouts
…enter-Camera Remote operator off-center camera
…update Steve rotate center element update
…t-Fixes Esc key, g focus, & zooming out fixes
hobinjk-ptc
force-pushed
the
stacking-order
branch
from
November 8, 2024 00:56
b55cbcc
to
a3c875c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ptcrealitylab/vuforia-spatial-toolbox-userinterface#434