859 #864
Merged
859 #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 19, 2024 10:27
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+72
to
+109
| configVisServer.get('/', async (request, reply) => { | ||
| // Obfuscate the config object before sending it to the client | ||
| // First get clean copy of the config object | ||
| let newConfig = JSON.parse(JSON.stringify(globals.config)); | ||
|
|
||
| if (globals.config.get('Butler-SOS.configVisualisation.obfuscate')) { | ||
| // Obfuscate config file before presenting it to the user | ||
| // This is done to avoid leaking sensitive information | ||
| // to users who should not have access to it. | ||
| // The obfuscation is done by replacing parts of the | ||
| // config file with masked strings. | ||
| newConfig = configObfuscate(newConfig); | ||
| } | ||
|
|
||
| // Convert the (potentially obfuscated) config object to YAML format (=string) | ||
| const butlerConfigYaml = yaml.dump(newConfig); | ||
|
|
||
| // Read index.html from disk | ||
| // dirname points to the directory where this file (app.js) is located, taking into account | ||
| // if the app is running as a packaged app or as a Node.js app. | ||
| globals.logger.verbose(`----------------3: ${globals.appBasePath}`); | ||
| const filePath = path.resolve(globals.appBasePath, 'static/configvis', 'index.html'); | ||
| const template = fs.readFileSync(filePath, 'utf8'); | ||
|
|
||
| // Compile handlebars template | ||
| const compiledTemplate = handlebars.compile(template); | ||
|
|
||
| // Get config as HTML encoded JSON string | ||
| const butlerConfigJsonEncoded = JSON.stringify(newConfig); | ||
|
|
||
| // Render the template | ||
| const renderedText = compiledTemplate({ butlerConfigJsonEncoded, butlerConfigYaml }); | ||
|
|
||
| globals.logger.debug(`CONFIG VIS: Rendered text: ${renderedText}`); | ||
|
|
||
| // Send reply as HTML | ||
| reply.code(200).header('Content-Type', 'text/html; charset=utf-8').send(renderedText); | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
| tokenize: function (e, n) { | ||
| var t = n.rest; | ||
| if (t) { | ||
| for (var r in t) n[r] = t[r]; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
| var t = n.rest; | ||
| if (t) { | ||
| for (var r in t) n[r] = t[r]; | ||
| delete n.rest; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.