BF: Keep settings after close / reopen #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeyus
commented
Oct 21, 2024
| @@ -145,6 +145,11 @@ def __init__(self, *args, **kwargs): | |||
| EyeTracker._keyboard = dev | |||
|
|
|||
| try: | |||
| # Add additional EyeLink command functions as options for the overloaded | |||
There was a problem hiding this comment.
this was moved to the top because the functions need to be available during the connection initialization
zeyus
commented
Oct 21, 2024
| else: | ||
| r = default_native_data_file_name.rfind('.') | ||
| if r > 0: | ||
| if default_native_data_file_name[r:].lower() == 'edf': |
There was a problem hiding this comment.
this line was also changed due to 'edf'.lower() doing nothing, now it lowers the data file name so 'EXP.EDF' would match
zeyus
commented
Oct 21, 2024
| @@ -289,6 +294,7 @@ def setConnectionState(self, enable): | |||
| self._eyelink.open(host_pc_ip_address) | |||
| pylink.flushGetkeyQueue() | |||
| self._eyelink.setOfflineMode() | |||
| self._initConnection() | |||
There was a problem hiding this comment.
this now attempts to configure the eyelink session for each time the connection is opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the connection state is closed and then opened again, the settings (such as the EDF file name) are gone. This just wraps the initial setup in a method that can be reused each time the connection state is reopened.