Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping corrections and new builder component #6

Merged
merged 14 commits into from
Sep 4, 2024

Conversation

domstoppable
Copy link
Collaborator

Fixes errors in mapping calculations from non-pix spatial units

@domstoppable domstoppable requested a review from mdcutone August 15, 2024 04:30
@domstoppable domstoppable changed the title Mapping corrections Mapping corrections and new builder component Sep 2, 2024
@domstoppable
Copy link
Collaborator Author

@mdcutone @TEParsons - we would love to get the merged in and pypi updated with these changes

@peircej
Copy link
Member

peircej commented Sep 3, 2024

@mdcutone @TEParsons - we would love to get the merged in and pypi updated with these changes

Hi @domstoppable I'm happy to pull this in when the tests pass (I noticed yesterday they failed) but it looks like they've progressed past yesterday's fail today (at least on linux)

@peircej
Copy link
Member

peircej commented Sep 3, 2024

Oh, the reason the tests are failing to find a runner on MacOS is that they're set to use macos-11 in the Github workflow. That's deprecated and needs moving to macos-13. macos-latest uses ARM architecture so probably best to avoid that for now.

@domstoppable domstoppable force-pushed the main branch 2 times, most recently from 7e433e7 to 79cdbda Compare September 4, 2024 00:22
@domstoppable
Copy link
Collaborator Author

Good call, @peircej - look ok now?

@peircej peircej merged commit e031b40 into psychopy:main Sep 4, 2024
3 checks passed
@peircej
Copy link
Member

peircej commented Sep 4, 2024

OK, great. So, to publish we need to:

  • update the version number in pyproject. Is this a pure bug-fix 0.2.2 or adds functionality 0.3.0? Or maybe we think this is really out of beta mode and call it 1.0.0. I'd say @domstoppable is best to make that judgement call
  • add a new tag on github to initiate the build/publish action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants