Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: remove onunhandledrejection but keep data-error #399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tpronk
Copy link
Contributor

@tpronk tpronk commented Jun 14, 2021

This is an alternative to PR #398, which keeps in the data-error part in window.onerror, which is useful for our automated testing. As this testrun illustrates, this approach does seem to close #367 and close #397
https://github.com/psychopy/psychojs/runs/2824210423?check_suite_focus=true

As @thewhodidthis did in his PR, I removed the window.onunhandledrejection, but I'd like to check with @apitiot whether this might not cause other issues?

@tpronk
Copy link
Contributor Author

tpronk commented Jun 14, 2021

I ran the wdio_video test on all our BrowserStack platforms; they all passed (including iOS). https://staging.psychopy.org/results_wdio/main/short/wdio_video/logs_processed/

@apitiot
Copy link
Contributor

apitiot commented Jun 15, 2021

@tpronk @thewhodidthis This is a slightly tricky issue. onunhandledrejection is necessary to capture those errors that occurred in the various Promises we are now using. Removing it will prevent us from displaying those errors to participants, in a pop-up dialog window.
Let me look into that matter and we can discuss it all together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes brought in to help with #368 will break error handling on occasion Video component doesn't present
2 participants