BF: remove onunhandledrejection but keep data-error #399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to PR #398, which keeps in the
data-error
part inwindow.onerror
, which is useful for our automated testing. As this testrun illustrates, this approach does seem to close #367 and close #397https://github.com/psychopy/psychojs/runs/2824210423?check_suite_focus=true
As @thewhodidthis did in his PR, I removed the
window.onunhandledrejection
, but I'd like to check with @apitiot whether this might not cause other issues?