Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Team Module Test #43

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Added Team Module Test #43

merged 3 commits into from
Dec 20, 2022

Conversation

khsarvar
Copy link
Contributor

@khsarvar khsarvar commented Dec 20, 2022

Added Team Module test
Fixes #38

@khsarvar khsarvar requested a review from Smullz622 December 20, 2022 18:43
@khsarvar khsarvar self-assigned this Dec 20, 2022
require 'rails_helper'

RSpec.describe Team, type: :model do
let(:new_team) do Team.new(id: 1, team: "123", manager: 2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just put Team.new etc on a new line & indented under let and it will be good to go

@khsarvar khsarvar requested a review from Smullz622 December 20, 2022 18:58
Copy link
Contributor

@Smullz622 Smullz622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing I just noticed, let's rename the file to team_spec.rb vs team_model.rb to align with our naming conventions. You can do this directly from Github if you want

Copy link
Contributor

@Smullz622 Smullz622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@khsarvar khsarvar merged commit b0cf700 into main Dec 20, 2022
@khsarvar khsarvar deleted the Team_module_test branch December 20, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model spec for team
2 participants