Add Oracle document store classes #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| void testFile() { | ||
| String pref = "{\"file\": \"" + dotenv.get("DEMO_DS_PDF_FILE") + "\"}"; | ||
| List<Document> docs = loader.loadDocuments(pref); | ||
| assertThat(docs.size()).isEqualTo(1); |
There was a problem hiding this comment.
Suggested change
| assertThat(docs.size()).isEqualTo(1); | |
| assertThat(docs).hasSize(1); |
| textSegments.add(TextSegment.from("goodbye world")); | ||
| textSegments.add(TextSegment.from("1,2,3")); | ||
| Response<List<Embedding>> resp3 = embedder.embedAll(textSegments); | ||
| assertThat(resp3.content().size()).isEqualTo(3); |
There was a problem hiding this comment.
Suggested change
| assertThat(resp3.content().size()).isEqualTo(3); | |
| assertThat(resp3.content()).hasSize(3); |
| textSegments.add(TextSegment.from("goodbye world")); | ||
| textSegments.add(TextSegment.from("1,2,3")); | ||
| Response<List<Embedding>> resp3 = embedder.embedAll(textSegments); | ||
| assertThat(resp3.content().size()).isEqualTo(3); |
There was a problem hiding this comment.
Suggested change
| assertThat(resp3.content().size()).isEqualTo(3); | |
| assertThat(resp3.content()).hasSize(3); |
psilberk
reviewed
Nov 19, 2024
|
|
||
| documents.addAll(loadDocuments(owner, table, column, pref)); | ||
| } else { | ||
| throw new RuntimeException("Invalid preference"); |
There was a problem hiding this comment.
I think we should add more information in here, and it's probably more a InvalidParameterException: https://docs.oracle.com/javase/8/docs/api/java/security/InvalidParameterException.html
psilberk
reviewed
Nov 19, 2024
| throw new RuntimeException("Invalid preference"); | ||
| } | ||
| } catch (IOException | RuntimeException ex) { | ||
| String message = ex.getCause() != null ? ex.getCause().getMessage() : ex.getMessage(); |
There was a problem hiding this comment.
You don't need to catch the RuntimeException, and I think we should re-throw the exception if we can't recover from the IOException: https://www.baeldung.com/java-exceptions
psilberk
reviewed
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #
Change
Add Oracle document store classes
General checklist
Checklist for adding new maven module
pom.xmlandlangchain4j-bom/pom.xmlChecklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreITthat extends from eitherEmbeddingStoreITorEmbeddingStoreWithFilteringIT{NameOfIntegration}EmbeddingStoreRemovalITthat extends fromEmbeddingStoreWithRemovalITChecklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStoreworks correctly with the data persisted using the latest released version of LangChain4j