V5 compatibility and features #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'll try to test it out as soon as possible. The massive WordPress project I was on has been completed and I'm currently working on non-WordPress projects. Hopefully, others can test this out. Thanks for this. |
mcaskill
requested changes
Nov 29, 2023
kkmuffme
force-pushed
the
v5-compatibility-and-features
branch
from
869c0ff
to
2c82294
Compare
mcaskill
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mcaskill finally I had some time to PR it; my fork was quite different already and I had to remove a couple things that are internal, so it took a bit more time.
It's been almost 2 years since I wrote some of the code, and I'm much more familiar with psalm's code base now than I was then, so I already see a variety of things that can be improved upon eventually.
If you could take a quick look and run this branch for a few days in your codebase, to identify any issues/points you want to change upon, that would be great.
Otherwise, I'd say we merge this, and then add/merge the few changes of https://github.com/psalm/psalm-plugin-wordpress/pull/42/files, which aren't part of this PR already, to it (if you don't want to do that, I'm fine to do that chore)
--
This PR adds compatibility with psalm v5, new phpparser version (afair 4.16 or something), support for dynamic hook names, some support for cron hooks, errors for deprecated hooks, handling for hooks without docs, and tons of other stuff.
Fix #18