Merge pull request #344 from lptn/update-baseline

Update baseline
psalm · Jul 13, 2023 · 722648c · 722648c
2 parents 61a1ca4 + ad472c5
commit 722648c
Show file tree

Hide file tree

Showing 9 changed files with 39 additions and 3 deletions.
diff --git a/composer.json b/composer.json
@@ -68,7 +68,7 @@
         "lint": "phpcs --report-full --report-summary --colors -n -s",
         "lint-fix": "phpcbf -n",
         "psalm": "psalm --find-dead-code --find-unused-psalm-suppress --long-progress --output-format=phpstorm",
-        "psalm-set-baseline": "@php ./psalm --set-baseline=psalm-baseline.xml",
+        "psalm-set-baseline": "psalm --set-baseline=psalm-baseline.xml",
         "test": [
             "@lint",
             "@psalm",

diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="5.7.7@e028ba46ba0d7f9a78bc3201c251e137383e145f">
+<files psalm-version="5.13.1@086b94371304750d1c673315321a55d15fc59015">
   <file src="src/Handlers/Auth/AuthConfigAnalyzer.php">
     <LessSpecificReturnStatement>
       <code><![CDATA['\Illuminate\Auth\GenericUser']]></code>
@@ -21,11 +21,36 @@
       <code>null</code>
     </TypeDoesNotContainType>
   </file>
+  <file src="src/Handlers/Auth/GuardHandler.php">
+    <DeprecatedProperty>
+      <code><![CDATA[$previous_call->name->parts]]></code>
+    </DeprecatedProperty>
+  </file>
   <file src="src/Handlers/Eloquent/ModelPropertyAccessorHandler.php">
+    <ArgumentTypeCoercion>
+      <code><![CDATA[$event->getFqClasslikeName()]]></code>
+      <code><![CDATA[$event->getFqClasslikeName()]]></code>
+      <code><![CDATA[$event->getFqClasslikeName()]]></code>
+    </ArgumentTypeCoercion>
     <LessSpecificImplementedReturnType>
       <code>array</code>
       <code>array</code>
       <code>array</code>
     </LessSpecificImplementedReturnType>
   </file>
+  <file src="src/Handlers/Eloquent/Schema/SchemaAggregator.php">
+    <DeprecatedProperty>
+      <code><![CDATA[$first_argument_of_nullable->value->name->parts]]></code>
+    </DeprecatedProperty>
+  </file>
+  <file src="src/Handlers/Helpers/PathHandler.php">
+    <InternalMethod>
+      <code>new TLiteralString($result)</code>
+    </InternalMethod>
+  </file>
+  <file src="src/Util/ContainerResolver.php">
+    <InternalMethod>
+      <code>new TLiteralString($concrete)</code>
+    </InternalMethod>
+  </file>
 </files>
diff --git a/src/Handlers/Eloquent/ModelPropertyAccessorHandler.php b/src/Handlers/Eloquent/ModelPropertyAccessorHandler.php
@@ -88,6 +88,7 @@ public static function getPropertyType(PropertyTypeProviderEvent $event): ?Type\
         return null;
     }
 
+    /** @param class-string $fqcn */
     private static function hasNativeProperty(string $fqcn, string $property_name): bool
     {
         try {

diff --git a/src/Plugin.php b/src/Plugin.php
@@ -55,6 +55,7 @@ protected function getCommonStubs(): array
         return array_merge(
             glob(dirname(__DIR__) . '/stubs/Collections/*.stubphp'),
             glob(dirname(__DIR__) . '/stubs/Contracts/*.stubphp'),
+            glob(dirname(__DIR__) . '/stubs/Database/Eloquent/*.stubphp'),
             glob(dirname(__DIR__) . '/stubs/Database/*.stubphp'),
             glob(dirname(__DIR__) . '/stubs/Foundation/*.stubphp'),
             glob(dirname(__DIR__) . '/stubs/Http/*.stubphp'),

diff --git a/stubs/Database/Builder.stubphp → stubs/Database/Eloqeunt/Builder.stubphp b/stubs/Database/Builder.stubphp → stubs/Database/Eloqeunt/Builder.stubphp
diff --git a/stubs/Database/Model.stubphp → stubs/Database/Eloqeunt/Model.stubphp b/stubs/Database/Model.stubphp → stubs/Database/Eloqeunt/Model.stubphp
diff --git a/stubs/Database/FactoryBuilder.stubphp → ...s/legacy-factories/FactoryBuilder.stubphp b/stubs/Database/FactoryBuilder.stubphp → ...s/legacy-factories/FactoryBuilder.stubphp
@@ -3,7 +3,6 @@
 namespace Illuminate\Database\Eloquent;
 
 use Faker\Generator as Faker;
-use InvalidArgumentException;
 use Illuminate\Support\Traits\Macroable;
 
 /**

diff --git a/tests/Application/laravel-test-baseline.xml b/tests/Application/laravel-test-baseline.xml
@@ -21,6 +21,9 @@
     </UnusedClass>
   </file>
   <file src="app/Console/Commands/ExampleCommand.php">
+    <MissingReturnType>
+      <code>handle</code>
+    </MissingReturnType>
     <UnusedClass>
       <code>ExampleCommand</code>
     </UnusedClass>

diff --git a/tests/Application/lumen-test-baseline.xml b/tests/Application/lumen-test-baseline.xml
@@ -39,11 +39,18 @@
       <code>handle</code>
     </PossiblyUnusedMethod>
   </file>
+  <file src="app/Models/User.php">
+    <PropertyNotSetInConstructor>
+      <code>User</code>
+      <code>User</code>
+    </PropertyNotSetInConstructor>
+  </file>
   <file src="app/Providers/AuthServiceProvider.php">
     <MissingClosureParamType>
       <code>$request</code>
     </MissingClosureParamType>
     <MixedMethodCall>
+      <code>first</code>
       <code>input</code>
       <code>input</code>
     </MixedMethodCall>